Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provisionally removes previously added literal profile from SSSOM #383

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

matentzn
Copy link
Collaborator

@matentzn matentzn commented Aug 4, 2024

Intermediate PR to make it easier to review the new solution for representing the literal profile.

Note to reviewers: Whoever approves this, intrinsically approves also #384 (modulo details). The point to merging this first is to make reviewing #384 much easier.

@matentzn matentzn added the schema label Aug 4, 2024
@matentzn matentzn self-assigned this Aug 4, 2024
@matentzn matentzn marked this pull request as ready for review August 6, 2024 13:47
@matentzn matentzn requested review from gouttegd and hrshdhgd August 6, 2024 13:47
@matentzn matentzn changed the title Entirely removes previously added literal profile from SSSOM Provisionally removes previously added literal profile from SSSOM Aug 6, 2024
@matentzn matentzn merged commit bd03f7b into master Aug 6, 2024
3 checks passed
@matentzn matentzn deleted the remove-literal-profile branch August 6, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants