Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Devtools fixes and improvements #366

Merged
merged 2 commits into from
Nov 11, 2023

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented Nov 3, 2023

No description provided.

Copy link

github-actions bot commented Nov 3, 2023

Benchmark for 51f636b

Click to view benchmark
Test Base PR %
benchmarks/big trees (deep + branches + cached) + invalidated node in the middle 987.9±83.38µs 970.4±69.22µs -1.77%
benchmarks/big trees (deep + cached) + invalidated node in the bottom 82.0±1.52µs 85.7±69.26µs +4.51%
benchmarks/big trees (deep + cached) + invalidated node in the middle 96.9±4.77µs 99.1±65.30µs +2.27%
benchmarks/big trees (deep + cached) + invalidated node in the top 152.8±3.01µs 151.9±1.63µs -0.59%
benchmarks/big trees (deep) nodes=10000, depth=14 206.0±6.99µs 202.4±6.49µs -1.75%
benchmarks/big trees (deep) nodes=100000, depth=17 3.2±0.08ms 3.3±0.13ms +3.13%
benchmarks/big trees (deep) nodes=4000, depth=12 100.6±3.36µs 101.1±6.18µs +0.50%
benchmarks/big trees (wide) nodes=1000, depth=1 154.1±1.64µs 149.2±1.59µs -3.18%
benchmarks/big trees (wide) nodes=10000, depth=1 1600.5±15.59µs 2.0±0.05ms +24.96%
benchmarks/big trees (wide) nodes=100000, depth=1 30.6±0.31ms 29.8±0.55ms -2.61%

Copy link

codecov bot commented Nov 4, 2023

Codecov Report

Attention: 68 lines in your changes are missing coverage. Please review.

Comparison is base (f3813c1) 53.60% compared to head (536e9e3) 53.36%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #366      +/-   ##
==========================================
- Coverage   53.60%   53.36%   -0.24%     
==========================================
  Files         133      133              
  Lines       12074    12127      +53     
==========================================
  Hits         6472     6472              
- Misses       5602     5655      +53     
Files Coverage Δ
crates/torin/src/values/size.rs 66.66% <0.00%> (ø)
crates/components/src/scroll_views/scroll_view.rs 0.00% <0.00%> (ø)
...components/src/scroll_views/virtual_scroll_view.rs 0.00% <0.00%> (ø)
crates/torin/src/values/alignment.rs 40.00% <0.00%> (-17.15%) ⬇️
crates/devtools/src/tab.rs 0.00% <0.00%> (ø)
crates/state/src/values/font.rs 17.50% <0.00%> (-1.42%) ⬇️
crates/components/src/scroll_views/scroll_bar.rs 0.00% <0.00%> (ø)
crates/devtools/src/tabs/style.rs 0.00% <0.00%> (ø)
crates/core/src/node.rs 14.04% <0.00%> (-2.30%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 4, 2023

Benchmark for eb09ab6

Click to view benchmark
Test Base PR %
benchmarks/big trees (deep + branches + cached) + invalidated node in the middle 1281.5±62.80µs 1291.2±153.47µs +0.76%
benchmarks/big trees (deep + cached) + invalidated node in the bottom 125.5±15.12µs 127.1±53.36µs +1.27%
benchmarks/big trees (deep + cached) + invalidated node in the middle 144.4±31.07µs 135.5±58.16µs -6.16%
benchmarks/big trees (deep + cached) + invalidated node in the top 222.5±0.79µs 222.1±1.07µs -0.18%
benchmarks/big trees (deep) nodes=10000, depth=14 279.0±3.90µs 281.7±11.15µs +0.97%
benchmarks/big trees (deep) nodes=100000, depth=17 4.1±0.22ms 4.0±0.16ms -2.44%
benchmarks/big trees (deep) nodes=4000, depth=12 130.2±1.11µs 129.9±1.31µs -0.23%
benchmarks/big trees (wide) nodes=1000, depth=1 194.8±1.05µs 195.1±13.44µs +0.15%
benchmarks/big trees (wide) nodes=10000, depth=1 2.1±0.01ms 2.3±0.01ms +9.52%
benchmarks/big trees (wide) nodes=100000, depth=1 38.8±0.63ms 38.4±0.55ms -1.03%

@marc2332 marc2332 mentioned this pull request Nov 4, 2023
@marc2332 marc2332 added enhancement 🔥 New feature or request devtools labels Nov 4, 2023
@marc2332 marc2332 marked this pull request as ready for review November 11, 2023 16:05
@marc2332 marc2332 merged commit 1afdce9 into main Nov 11, 2023
7 of 8 checks passed
@marc2332 marc2332 deleted the feat/devtools-fixes-and-improvements branch November 11, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devtools enhancement 🔥 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant