[Zelda BOTW only] Improved change of savedata format #136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Changes in this commit are:
data when changing endianess. This is because when endianess is changed,
item data is corrupted. This clipboard is a workaround for that issue.
setting item data.
created via the Savegame Editor.
Testing
Tested locally (loading index.html) and once commit was pushed in https://pablopenna.github.io/savegame-editors/zelda-botw/
I successfully exported the savegame from my switch to Cemu.
Although I have only worked on items, some other player data is not corrupted and is exported just fine (e.g. Link's health, stamina or event flags).
Known Issues (when changing endianess)
NOTES:
I reused some pieces of code, hence duplicating some pieces of logic. I could have done a refactor but I tried to modify the original code the less possible.
I recommend adding
?w=1
to the URL when checking the commit diff to ignore whitespace changes. My IDE removed trailing whitespaces from the files I touched.