tasks are implemented #1462
tasks are implemented #1462
Conversation
There was a problem hiding this comment.
Great job on implementing the task requirements! 🎉 The code is well-structured and meets all the core functionality as specified. While the use of the name attribute for labels and placeholders is functional, consider using more descriptive text for better user experience. Keep up the good work and continue refining your skills! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| @@ -1,3 +1,14 @@ | |||
| 'use strict'; | |||
|
|
|||
| // write code here | |||
| const inputs = [...document.querySelectorAll('input')]; | |||
There was a problem hiding this comment.
The code selects all input elements on the page. Ensure that each input element has a unique and meaningful 'name' attribute, as this is used for both the label text and placeholder.
| const label = document.createElement('label'); | ||
|
|
||
| label.classList.add('field-label'); | ||
| label.innerHTML = input.name.toUpperCase(); |
There was a problem hiding this comment.
Using the 'name' attribute for the label text may not always be user-friendly. Consider using a more descriptive text for labels if the 'name' attribute is not descriptive enough.
| label.setAttribute('for', input.id); | ||
| input.parentNode.prepend(label); | ||
|
|
||
| input.setAttribute('placeholder', input.name.toUpperCase()); |
There was a problem hiding this comment.
Using the 'name' attribute for the placeholder text may not always be user-friendly. Consider using a more descriptive text for placeholders if the 'name' attribute is not descriptive enough.
|
explain what's wrong |
No description provided.