Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tasks are implemented #1462

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+14 −3
Open

tasks are implemented #1462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
1. Replace `<your_account>` with your Github username in the link
- [DEMO LINK](https://<your_account>.github.io/js_task_fix_form_DOM/)
- [DEMO LINK](https://SamarashEugene.github.io/js_task_fix_form_DOM/)
2. Follow [this instructions](https://mate-academy.github.io/layout_task-guideline/)
- Run `npm run test` command to test your code;
- Run `npm run test:only -- -n` to run fast test ignoring linter;
Expand Down
2 changes: 1 addition & 1 deletion src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<title>Login</title>
<link
rel="stylesheet"
href="./styles/main.scss"
href="./styles/main.css"
/>
</head>
<body>
Expand Down
13 changes: 12 additions & 1 deletion src/scripts/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,14 @@
'use strict';

// write code here
const inputs = [...document.querySelectorAll('input')];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code selects all input elements on the page. Ensure that each input element has a unique and meaningful 'name' attribute, as this is used for both the label text and placeholder.


for (const input of inputs) {
const label = document.createElement('label');

label.classList.add('field-label');
label.innerHTML = input.name.toUpperCase();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the 'name' attribute for the label text may not always be user-friendly. Consider using a more descriptive text for labels if the 'name' attribute is not descriptive enough.

label.setAttribute('for', input.id);
input.parentNode.prepend(label);

input.setAttribute('placeholder', input.name.toUpperCase());
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the 'name' attribute for the placeholder text may not always be user-friendly. Consider using a more descriptive text for placeholders if the 'name' attribute is not descriptive enough.

}
Loading