Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taskParseList #1538

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

WalentynaSadowa
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the task requirements! 🎉 Your code correctly parses salaries, sorts employees by salary, and retrieves employee details. Just a small tip: when working with NodeLists or HTMLCollections, consider converting them to arrays before sorting and appending elements to avoid any unexpected behavior. Keep up the good work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

return salaryB - salaryA;
});

sortedList.forEach((item) => list.appendChild(item));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appending sorted elements back to the original list using list.appendChild(item) may not work as expected if list is a NodeList or HTMLCollection, as these are live collections and appending elements may cause unexpected behavior. Consider converting list to an array before sorting and appending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants