Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taskParseList #1538

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions .github/workflows/test.yml-template
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
name: Test

on:
pull_request:
branches: [ master ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm start & sleep 5 && npm test
- name: Upload tests report(cypress mochaawesome merged HTML report)
if: ${{ always() }}
uses: actions/upload-artifact@v2
with:
name: report
path: reports
9 changes: 5 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"@linthtml/linthtml": "^0.9.6",
"@mate-academy/eslint-config": "latest",
"@mate-academy/linthtml-config": "latest",
"@mate-academy/scripts": "^1.8.5",
"@mate-academy/scripts": "^2.1.0",
"@mate-academy/stylelint-config": "latest",
"@parcel/transformer-sass": "^2.12.0",
"cypress": "^13.13.0",
Expand Down
38 changes: 36 additions & 2 deletions src/scripts/main.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,37 @@
'use strict';
function parseSalary(salaryString) {
return parseInt(salaryString, 10);
}

// write code here
function sortList(list) {
const sortedList = Array.from(list).sort((a, b) => {
const salaryA = parseSalary(a.dataset.salary);
const salaryB = parseSalary(b.dataset.salary);

return salaryB - salaryA;
});

sortedList.forEach((item) => list.appendChild(item));
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appending sorted elements back to the original list using list.appendChild(item) may not work as expected if list is a NodeList or HTMLCollection, as these are live collections and appending elements may cause unexpected behavior. Consider converting list to an array before sorting and appending.


function getEmployees(list) {
const employees = Array.from(list).map((item) => {
return {
name: item.dataset.name,
position: item.dataset.position,
salary: parseSalary(item.dataset.salary),
age: item.dataset.age,
};
});

return employees;
}

document.addEventListener('DOMContentLoaded', function () {
const employeeList = document.querySelectorAll('.employee');

sortList(employeeList);

const employees = getEmployees(employeeList);

alert(JSON.stringify(employees, null, 2));
});
Loading