-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Good #1730
base: master
Are you sure you want to change the base?
Good #1730
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
from __future__ import annotations | ||
from app.people.customer import Customer | ||
|
||
|
||
class CinemaBar: | ||
|
||
@staticmethod | ||
def sell_product(product: str, customer: Customer) -> None: | ||
product = customer.food | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The line |
||
print(f"Cinema bar sold {product} to {customer.name}.") |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
from __future__ import annotations | ||
from app.people.customer import Customer | ||
from app.people.cinema_staff import Cleaner | ||
|
||
|
||
class CinemaHall: | ||
def __init__(self, number: int) -> None: | ||
self.number = number | ||
|
||
def movie_session( | ||
self, | ||
movie_name: str, | ||
customers: Customer, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
cleaner_staff: Cleaner | ||
) -> None: | ||
print(f"\"{movie_name}\" started in hall number {self.number}.") | ||
for customer in customers: | ||
customer.watch_movie(movie_name) | ||
print(f"\"{movie_name}\" ended.") | ||
cleaner_staff.clean_hall(self.number) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,22 @@ | ||
# write your imports here | ||
from app.cinema.hall import CinemaHall | ||
from app.people.cinema_staff import Cleaner | ||
from app.people.customer import Customer | ||
from app.cinema.bar import CinemaBar | ||
|
||
|
||
def cinema_visit(customers: list, hall_number: int, cleaner: str, movie: str): | ||
# write you code here | ||
pass | ||
def cinema_visit( | ||
customers: list, | ||
hall_number: int, | ||
cleaner: str, | ||
movie: str | ||
) -> None: | ||
for i in range(len(customers)): | ||
customer_instance = [Customer(c["name"], c["food"]) for c in customers] | ||
cleaner_instance = Cleaner(cleaner) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
hall = CinemaHall(hall_number) | ||
for customer in customer_instance: | ||
Comment on lines
+13
to
+16
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is an unnecessary loop when creating instances of
Comment on lines
+13
to
+16
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The creation of |
||
CinemaBar.sell_product(customer=customer, product=customer.food) | ||
hall.movie_session( | ||
movie_name=movie, | ||
customers=customer_instance, | ||
cleaner_staff=cleaner_instance) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
from __future__ import annotations | ||
|
||
|
||
class Cleaner: | ||
def __init__(self, name: str) -> Cleaner: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
self.name = name | ||
|
||
def clean_hall(self, hall_number: int) -> Cleaner: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
print(f"Cleaner {self.name} is cleaning hall number {hall_number}.") |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
from __future__ import annotations | ||
|
||
|
||
class Customer: | ||
|
||
def __init__(self, name: str, food: str) -> None: | ||
self.name = name | ||
self.food = food | ||
|
||
def watch_movie(self, movie: str) -> None: | ||
print(f"{self.name} is watching \"{movie}\".") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
sell_product
method should use theproduct
parameter directly instead of overwriting it withcustomer.food
. This ensures that the method sells the product specified by the caller, not just the food associated with the customer.