Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prettier tooltips for KPI cards #23014

Open
wants to merge 8 commits into
base: 5.x-dev
Choose a base branch
from
Open

Add prettier tooltips for KPI cards #23014

wants to merge 8 commits into from

Conversation

caddoo
Copy link
Contributor

@caddoo caddoo commented Feb 5, 2025

Description:

Improves the tool tips for the KPI cards for all websites dashboard

(Ref: DEV-18917)

Review

@@ -137,6 +137,16 @@ describe('AllWebsitesDashboard', function () {

expect(await page.screenshotSelector('#main')).to.matchImage('dashboard_all_badges');
});

it('tooltip should show on hover of kpi card', async function() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested one KPI card tool tip, the logic is reused, I don't want to add too much additional time to the UI test suite.

@caddoo caddoo marked this pull request as ready for review February 5, 2025 02:58
@caddoo caddoo requested a review from a team February 5, 2025 02:58
@caddoo caddoo added the Needs Review PRs that need a code review label Feb 5, 2025
@caddoo caddoo requested a review from sgiehl February 6, 2025 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants