Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prettier tooltips for KPI cards #23014

Open
wants to merge 8 commits into
base: 5.x-dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/MobileMessaging/vue/dist/umd.metadata.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions plugins/MultiSites/tests/UI/AllWebsitesDashboard_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,16 @@ describe('AllWebsitesDashboard', function () {

expect(await page.screenshotSelector('#main')).to.matchImage('dashboard_all_badges');
});

it('tooltip should show on hover of kpi card', async function() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested one KPI card tool tip, the logic is reused, I don't want to add too much additional time to the UI test suite.

await page.goto(dashboardUrl);
await page.waitForNetworkIdle();

await page.hover('.kpiCardContainer .kpiCard:first-child .kpiCardValue');
await page.waitForTimeout(200);

expect(await page.screenshotSelector('.kpiCardContainer')).to.matchImage('dashboard_badge_tooltip');
});
});

describe('Revenue Column', function () {
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
65 changes: 46 additions & 19 deletions plugins/MultiSites/vue/dist/MultiSites.umd.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading