Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Tidy up _AppsDrawer.pcss #10775

Merged
merged 13 commits into from
May 11, 2023
Merged

Tidy up _AppsDrawer.pcss #10775

merged 13 commits into from
May 11, 2023

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented May 3, 2023

For element-hq/element-web#25268

This PR intends to tidy up _AppsDrawer.pcss, applying nesting and custom properties.

type: task

Signed-off-by: Suguru Hirahara [email protected]

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels May 3, 2023
@luixxiul luixxiul marked this pull request as ready for review May 3, 2023 06:27
@luixxiul luixxiul requested a review from a team as a code owner May 3, 2023 06:27
@robintown robintown removed the request for review from kerryarchibald May 10, 2023 13:33
@robintown
Copy link
Member

@luixxiul It looks like you have some merge conflicts now

@luixxiul
Copy link
Contributor Author

Fixing the conflict…

@andybalaam andybalaam added this pull request to the merge queue May 11, 2023
Merged via the queue into matrix-org:develop with commit 73007d6 May 11, 2023
richvdh pushed a commit that referenced this pull request May 12, 2023
* Nesting

* Run prettier

* Common style rules for `mx_AppTileBody` and `mx_AppTileBody_mini`

* Common style rules for iframe

* Use a custom property for height

* Replace with a custom property - $MiniAppTileHeight

* Replace with a custom property - $MinWidth

* Group common declarations

* Sorting
@luixxiul luixxiul deleted the AppsDrawer branch May 21, 2023 07:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants