This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
implement GpuProofConfig abstraction #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
6 tasks
EmilLuta
approved these changes
Feb 17, 2024
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "shivini" | |||
| version = "0.1.0" | |||
| version = "0.2.0" | |||
robik75
force-pushed
the
rr-gpu-config
branch
from
5877e8d to
f7ed31d
Compare
robik75
force-pushed
the
rr-gpu-config
branch
4 times, most recently
from
9a8165c to
c826c67
Compare
github-merge-queue bot
pushed a commit
to matter-labs/zksync-era
that referenced
this pull request
Mar 5, 2024
#1100) ## What ❔ This PR removes an expensive instantiation of a CSReferenceAssembly structure inside the FRI GPU prover. The prerequisite is matter-labs/era-shivini#37 ## Why ❔ The instantiation of a CSReferenceAssembly structure is too expensive and needed to be replaced with a faster alternative. ## Checklist - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zk fmt` and `zk lint`. - [ ] Spellcheck has been run via `zk spellcheck`. - [ ] Linkcheck has been run via `zk linkcheck`.
robik75
added a commit
that referenced
this pull request
Apr 8, 2024
This PR implements a GpuProofConfig abstraction to remove a dependency on CSReferenceAssembly structure. Instantiation of the CSReferenceAssembly structure is expensive so we need to enable the possibility to supply the pieces of configuration the prover needs in an alternative way. This abstraction makes it possible to generate the information either from the CSReferenceAssembly structure or directly from a Circuit structure. - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Tests for the changes have been added / updated. - [x] Documentation comments have been added / updated. - [x] Code has been formatted via `cargo fmt` and linted via `cargo check`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
This PR implements a GpuProofConfig abstraction to remove a dependency on CSReferenceAssembly structure.
Why ❔
Instantiation of the CSReferenceAssembly structure is expensive so we need to enable the possibility to supply the pieces of configuration the prover needs in an alternative way. This abstraction makes it possible to generate the information either from the CSReferenceAssembly structure or directly from a Circuit structure.
Checklist
cargo fmtand linted viacargo check.