-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hasUnpartitionedCookieAccess #33329
Conversation
@Elchi3 @pepelsbey Have time to review? |
Preview URLs (6 pages)Flaws (6)Note! 5 documents with no flaws that don't need to be listed. 🎉 URL:
External URLs (1)URL:
(comment last updated: 2024-05-21 20:59:46) |
@sideshowbarker I'm working on mdn/browser-compat-data#22978 but that's paused until the new spec I added to browser-specs propagates. Can this more forward before then? |
@Elchi3 @pepelsbey this is ready for review, the only flaw is that it's dependent on pulling two versions of packages newer than what's in the lockfile. |
This pull request has merge conflicts that must be resolved before it can be merged. |
@sideshowbarker have time for review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loog good in general, just a few suggestions :)
files/en-us/web/api/document/hasunpartitionedcookieaccess/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you :) Feel free to accept the suggestion if you agree.
Co-authored-by: Vadim Makeev <[email protected]>
I don't have permission to merge on this or the other one, could you do so? |
Description
This is the first of 3 PRs adding spec changes from https://privacycg.github.io/saa-non-cookie-storage/ launching in Chrome 125.
Motivation
hasUnpartitionedCookieAccess is a renaming of hasStorageAccess intended to provide more clarity around what storage is actually accessible. This is important as Chrome now supports requesting unpartitioned storage access with or without unpartitioned cookies.
Additional details
https://chromestatus.com/feature/5175585823522816
Related issues and pull requests
Relates to mdn/mdn#543