Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hasUnpartitionedCookieAccess #33329

Merged
merged 33 commits into from
May 22, 2024
Merged

Add hasUnpartitionedCookieAccess #33329

merged 33 commits into from
May 22, 2024

Conversation

arichiv
Copy link
Contributor

@arichiv arichiv commented Apr 30, 2024

Description

This is the first of 3 PRs adding spec changes from https://privacycg.github.io/saa-non-cookie-storage/ launching in Chrome 125.

Motivation

hasUnpartitionedCookieAccess is a renaming of hasStorageAccess intended to provide more clarity around what storage is actually accessible. This is important as Chrome now supports requesting unpartitioned storage access with or without unpartitioned cookies.

Additional details

https://chromestatus.com/feature/5175585823522816

Related issues and pull requests

Relates to mdn/mdn#543

@arichiv arichiv requested a review from a team as a code owner April 30, 2024 11:34
@arichiv arichiv requested review from Elchi3 and removed request for a team April 30, 2024 11:34
@arichiv arichiv changed the title Add hasUnpartitionedCookieAccess [IN PROGRESS] Add hasUnpartitionedCookieAccess Apr 30, 2024
@github-actions github-actions bot added Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed labels Apr 30, 2024
@arichiv arichiv requested a review from a team as a code owner April 30, 2024 11:47
@arichiv arichiv requested review from pepelsbey and removed request for a team April 30, 2024 11:47
@github-actions github-actions bot added size/m [PR only] 51-500 LoC changed and removed size/xs [PR only] 0-5 LoC changed labels Apr 30, 2024
@arichiv arichiv changed the title [IN PROGRESS] Add hasUnpartitionedCookieAccess Add hasUnpartitionedCookieAccess Apr 30, 2024
@arichiv
Copy link
Contributor Author

arichiv commented May 1, 2024

@Elchi3 @pepelsbey Have time to review?

Copy link
Contributor

github-actions bot commented May 1, 2024

Preview URLs (6 pages)
Flaws (6)

Note! 5 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/Document
Title: Document
Flaw count: 6

  • macros:
    • /en-US/docs/Web/API/Document/xmlStandalone does not exist
    • /en-US/docs/Web/API/Document/captureEvents does not exist
    • /en-US/docs/Web/API/Document/getBoxQuads does not exist
    • /en-US/docs/Web/API/Document/releaseEvents does not exist
    • /en-US/docs/Web/API/Document/queryCommandIndeterm does not exist
    • and 1 more flaws omitted
External URLs (1)

URL: /en-US/docs/Web/API/Document/hasUnpartitionedCookieAccess
Title: Document: hasUnpartitionedCookieAccess() method

(comment last updated: 2024-05-21 20:59:46)

@arichiv
Copy link
Contributor Author

arichiv commented May 2, 2024

@sideshowbarker I'm working on mdn/browser-compat-data#22978 but that's paused until the new spec I added to browser-specs propagates. Can this more forward before then?

@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label May 5, 2024
@arichiv
Copy link
Contributor Author

arichiv commented May 5, 2024

@Elchi3 @pepelsbey this is ready for review, the only flaw is that it's dependent on pulling two versions of packages newer than what's in the lockfile.

@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label May 15, 2024
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed system [PR only] Infrastructure and configuration for the project merge conflicts 🚧 [PR only] labels May 15, 2024
@arichiv
Copy link
Contributor Author

arichiv commented May 21, 2024

@sideshowbarker have time for review?

Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loog good in general, just a few suggestions :)

@arichiv arichiv requested a review from pepelsbey May 21, 2024 16:45
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you :) Feel free to accept the suggestion if you agree.

files/en-us/web/api/document/hasstorageaccess/index.md Outdated Show resolved Hide resolved
@arichiv
Copy link
Contributor Author

arichiv commented May 21, 2024

I don't have permission to merge on this or the other one, could you do so?

@sideshowbarker sideshowbarker merged commit b97c61b into mdn:main May 22, 2024
9 checks passed
@arichiv arichiv deleted the patch-2 branch May 22, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants