Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StorageAccessHandle #33391

Merged
merged 29 commits into from
May 22, 2024
Merged

Add StorageAccessHandle #33391

merged 29 commits into from
May 22, 2024

Conversation

arichiv
Copy link
Contributor

@arichiv arichiv commented May 3, 2024

Description

This is the third of 3 PRs adding spec changes from https://privacycg.github.io/saa-non-cookie-storage/ launching in Chrome 125.

Motivation

StorageAccessHandle can be returned by requestStorageAccess when a types argument is provided to allow non-cookie unpartitioned storage access.

Additional details

https://chromestatus.com/feature/5175585823522816

Related issues and pull requests

Relates to mdn/mdn#543

@arichiv arichiv requested a review from a team as a code owner May 3, 2024 12:08
@arichiv arichiv requested review from wbamberg and removed request for a team May 3, 2024 12:08
@arichiv arichiv changed the title Add StorageAccessHandle Add StorageAccessHandle [WIP] May 3, 2024
@github-actions github-actions bot added the Content:WebAPI Web API docs label May 3, 2024
@github-actions github-actions bot added the size/s [PR only] 6-50 LoC changed label May 3, 2024
@github-actions github-actions bot added size/m [PR only] 51-500 LoC changed and removed size/s [PR only] 6-50 LoC changed labels May 3, 2024
@arichiv arichiv requested review from mdn-bot and a team as code owners May 3, 2024 12:43
@arichiv arichiv requested review from bsmth and removed request for a team May 3, 2024 12:43
@github-actions github-actions bot added the system [PR only] Infrastructure and configuration for the project label May 3, 2024
arichiv and others added 5 commits May 3, 2024 13:01
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
arichiv and others added 3 commits May 3, 2024 09:03
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@arichiv
Copy link
Contributor Author

arichiv commented May 5, 2024

@wbamberg @bsmth this is ready for review, the only flaw is that it's dependent on pulling two versions of packages newer than what's in the lockfile.

yarn.lock Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the system [PR only] Infrastructure and configuration for the project label May 15, 2024
@arichiv arichiv requested a review from bsmth May 15, 2024 17:50
@arichiv
Copy link
Contributor Author

arichiv commented May 21, 2024

@bsmth have time for review?

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had a read through when you originally opened and checked again today, so I would leave a +1 to unblock you. Maybe @pepelsbey wants to have a look, but I think we can land it, IMO. Thank you!

@bsmth bsmth requested a review from pepelsbey May 21, 2024 14:22
@arichiv
Copy link
Contributor Author

arichiv commented May 21, 2024

Thanks! I could also use an eye on #33329 if you have time

Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a suggestion on how to improve the readability of the parameters section. Otherwise, it looks good to me :)

files/en-us/web/api/document/requeststorageaccess/index.md Outdated Show resolved Hide resolved
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@arichiv
Copy link
Contributor Author

arichiv commented May 22, 2024

@sideshowbarker have time to merge this one too?

@pepelsbey pepelsbey merged commit b4355ef into mdn:main May 22, 2024
9 checks passed
@arichiv arichiv deleted the patch-3 branch May 22, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/l [PR only] 501-1000 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants