Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for getting/setting object arrays #60

Closed
mhostetter opened this issue Apr 9, 2021 · 2 comments · Fixed by #247
Closed

Add tests for getting/setting object arrays #60

mhostetter opened this issue Apr 9, 2021 · 2 comments · Fixed by #247
Assignees
@mhostetter
Labels
testing Relates to unit testing or test coverage
Milestone
Release 0.1.0

Comments

@mhostetter
Copy link
Owner

It's easy for dtype=object arrays to have elements with GFArray instances, not ints. That later causes issues when doing arithmetic. I'm adding intercepting features in the getters/setters, but I need to robustly test it.
@mhostetter mhostetter added the testing Relates to unit testing or test coverage label Apr 9, 2021
@mhostetter mhostetter self-assigned this Apr 9, 2021
@mhostetter
Copy link
Owner Author

Added checks in getters/setters in 3d06e78.

@mhostetter mhostetter added this to the Release 0.1.0 milestone Jul 24, 2021
@mhostetter mhostetter linked a pull request Aug 5, 2021 that will close this issue
Unit test review before 0.1.0 release #164
Merged
@mhostetter mhostetter removed a link to a pull request Aug 8, 2021
Unit test review before 0.1.0 release #164
Merged
@mhostetter mhostetter linked a pull request Aug 8, 2021 that will close this issue
Additional unit testing review #169
Merged
@mhostetter mhostetter removed a link to a pull request Aug 9, 2021
Additional unit testing review #169
Merged
@mhostetter mhostetter linked a pull request Aug 20, 2021 that will close this issue
Clean-up Galois field array code and tests #173
Merged
@mhostetter mhostetter removed a link to a pull request Aug 24, 2021
Clean-up Galois field array code and tests #173
Merged
@mhostetter mhostetter linked a pull request Jan 28, 2022 that will close this issue
Clean up unit tests #247
Merged
@mhostetter mhostetter mentioned this issue Feb 10, 2022
Closed
@mhostetter
Copy link
Owner Author

It is no longer required to cast inputs from __setitem__() to int. Instead, the pure-Python ufuncs themselves are doing the casting (as implemented in the fix for #253).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhostetter mhostetter

Labels
testing Relates to unit testing or test coverage
Projects
None yet
Milestone
Release 0.1.0
Development

Successfully merging a pull request may close this issue.

Clean up unit tests mhostetter/galois
1 participant
@mhostetter