Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up unit tests #247

Merged
merged 65 commits into from
Feb 10, 2022
Merged

Clean up unit tests #247

merged 65 commits into from
Feb 10, 2022

Conversation

mhostetter
Copy link
Owner

No description provided.

@mhostetter mhostetter added the testing Relates to unit testing or test coverage label Jan 28, 2022
This was linked to issues Jan 28, 2022
Catch unsupported ufunc kwargs #34
Open
Add tests for getting/setting object arrays #60
Closed
Complete unit testing review/overhaul #155
Closed
@codecov
Copy link

codecov bot commented Jan 28, 2022 •
edited
Loading

Codecov Report

Merging #247 (1e1674a) into master (a5e6386) will decrease coverage by 92.89%.
The diff coverage is n/a.

❗ Current head 1e1674a differs from pull request most recent head 3943e4a. Consider uploading reports for the commit 3943e4a to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #247       +/-   ##
=========================================
- Coverage   92.89%      0   -92.90%     
=========================================
  Files          31      0       -31     
  Lines        4770      0     -4770     
=========================================
- Hits         4431      0     -4431     
+ Misses        339      0      -339
Impacted Files Coverage Δ
galois/__init__.py
galois/_codes/_bch.py
galois/_codes/_reed_solomon.py
galois/_fields/_factory.py
galois/_fields/_linalg.py
galois/_fields/_main.py
galois/_fields/_poly_functions.py
galois/_math.py
galois/_modular.py
galois/_polymorphic.py
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5e6386...3943e4a. Read the comment docs.

@mhostetter mhostetter force-pushed the review-unit-tests branch 4 times, most recently from 5ab58f0 to e5e8df2 Compare January 30, 2022 19:40
@mhostetter
Make each unit test LUT reproducible with unique seed
f5ef83a
@mhostetter
Move unit test LUT folders
b48cc9b
@mhostetter
Rename field fixtures for unit tests
d137bd1
@mhostetter
Add more additive_order() unit tests
0bbbd73
@mhostetter
Add more multiplicative_order() unit tests
0b16c27
@mhostetter
Add more characteristic_poly() unit tests for 0-D scalars
af2c1db
@mhostetter
Add more characteristic_poly() unit tests for matrices
9ed44e9
@mhostetter
Add more minimal_poly() unit tests for 0-D scalars
5b2ffa8
@mhostetter
Add more field_trace() unit tests
259b0d9
@mhostetter
Add more field_norm() unit tests
05bdc96
@mhostetter
Add more matrix multiplication unit tests
ae437a0
@mhostetter
Add unit tests for row_reduce()
a810445
@mhostetter
Add more lu_decompose() unit tests
21099e0
@mhostetter
Refactor lup_decompose() into plu_decompose()
3d6f0cd
@mhostetter
Add unit tests for matrix inverses
3d11b75
@mhostetter
Add more matrix determinant unit tests
8af213d
@mhostetter
Add more np.linalg.solve() unit tests
7c251c8
@mhostetter
Instruct code coverage to ignore typing overloads
2ac2639
@mhostetter
Support non-square matrices for LU and PLU decomposition
7178b56 
Fixes #248
@mhostetter
Increase linear algebra code coverage
f5695e6
@mhostetter
Raise ValueError on polynomial CRT if remainder degrees not less th…
c6aee82 
…an moduli degrees

Fixes #252
@mhostetter
Add unit tests for polynomial CRT
ae25286
@mhostetter
Add more euler_phi() unit tests
ed5192f
@mhostetter
Add more carmichael_lambda() unit tests
b1ce6fe
@mhostetter
Add more is_cyclic() unit tests
a399365
@mhostetter
Add more primes() unit tests
25b3d85
@mhostetter
Add more kth_prime() unit tests
b4d011c
@mhostetter
Raise ValueError instead of returning None for invalid previous p…
b5467a5 
…rime
@mhostetter
Add more prev_prime() unit tests
ae85d99
@mhostetter
Add more next_prime() unit tests
2e4f5ab
@mhostetter
Allow negative integers to is_prime()
8afe920
@mhostetter
Add more is_prime() unit tests
3ed4dca
@mhostetter
Allow negative integers to is_composite()
60bb49a
@mhostetter
Allow negative integers to is_prime_power()
31a9e2a
@mhostetter
Add more is_prime_power() unit tests
c73aec9
@mhostetter
Make perfect_power() and is_perfect_power() more consistent with …
4b13001 
…Sage
@mhostetter
Add is_perfect_power() unit tests
20c6961
@mhostetter
Add more unit tests for testing square-free integers
044ee27
@mhostetter
Accept non-monic polynomials to is_square_free()
a048049
@mhostetter
Add more is_monic() unit tests
0bdd4d9
@mhostetter mhostetter removed a link to an issue Feb 10, 2022
Catch unsupported ufunc kwargs #34
Open
@mhostetter mhostetter marked this pull request as ready for review February 10, 2022 19:29
@mhostetter mhostetter merged commit 3aa7d1b into master Feb 10, 2022
@mhostetter mhostetter deleted the review-unit-tests branch February 10, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
testing Relates to unit testing or test coverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Complete unit testing review/overhaul Add tests for getting/setting object arrays
1 participant
@mhostetter