Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test review before 0.1.0 release #164

Merged
merged 26 commits into from
Aug 8, 2021
Merged

Unit test review before 0.1.0 release #164

merged 26 commits into from
Aug 8, 2021

Conversation

mhostetter
Copy link
Owner

No description provided.

@mhostetter mhostetter added the testing Relates to unit testing or test coverage label Aug 5, 2021
@mhostetter mhostetter added this to the Release 0.1.0 milestone Aug 5, 2021
@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #164 (c4b0383) into master (b6d8927) will increase coverage by 3.64%.
The diff coverage is 96.12%.

❗ Current head c4b0383 differs from pull request most recent head 2342e4f. Consider uploading reports for the commit 2342e4f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
+ Coverage   88.62%   92.26%   +3.64%     
==========================================
  Files          36       36              
  Lines        4106     4125      +19     
==========================================
+ Hits         3639     3806     +167     
+ Misses        467      319     -148     
Impacted Files Coverage Δ
galois/__init__.py 100.00% <ø> (ø)
galois/_field/_array.py 88.49% <ø> (ø)
galois/_lfsr.py 74.78% <ø> (+14.09%) ⬆️
galois/_field/_factory_prime.py 91.66% <82.35%> (+11.11%) ⬆️
galois/_field/_meta_class.py 91.11% <93.54%> (-1.20%) ⬇️
galois/_field/_poly_functions.py 97.65% <98.07%> (+2.42%) ⬆️
galois/_code/_bch.py 97.48% <100.00%> (+11.19%) ⬆️
galois/_code/_linear.py 92.59% <100.00%> (+70.37%) ⬆️
galois/_factor.py 86.04% <100.00%> (+2.20%) ⬆️
galois/_field/_factory.py 100.00% <100.00%> (+18.75%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6d8927...2342e4f. Read the comment docs.

@mhostetter mhostetter force-pushed the review-testing branch 2 times, most recently from af18ab0 to c7e1ed5 Compare August 5, 2021 17:33
@mhostetter mhostetter marked this pull request as draft August 5, 2021 19:25
@mhostetter mhostetter force-pushed the review-testing branch 3 times, most recently from 778e402 to 98c6688 Compare August 7, 2021 04:48
@mhostetter mhostetter force-pushed the review-testing branch 8 times, most recently from 8256ee3 to 3b2fde7 Compare August 7, 2021 08:11
@mhostetter mhostetter marked this pull request as ready for review August 8, 2021 01:00
@mhostetter mhostetter merged commit 1c1be4c into master Aug 8, 2021
@mhostetter mhostetter deleted the review-testing branch August 8, 2021 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Relates to unit testing or test coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow strings for poly kwargs GF class factory should not update display method if already exists
1 participant