workaround for 'function iconTexture.get_names does not exist' #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
gnome-shell 3.38.3-1 @ debian testing
|
tocomo
changed the title
3v1n0
requested changes
Aug 25, 2022
Comment on lines
+941
to
+948
| // sometime function iconTexture.get_names does not exist: JS ERROR: TypeError: iconTexture.get_names is not a function | ||
| if (iconTexture.get_names) { | ||
| let icon_info = themeLoader.lookup_icon(iconTexture.get_names()[0], DOMINANT_COLOR_ICON_SIZE, 0); | ||
| if (icon_info !== null) | ||
| return icon_info.load_icon(); | ||
| else | ||
| return null; | ||
| } |
There was a problem hiding this comment.
I think you can just early:
if (!iconTexture.get_names)
return null;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am playing around with a lot of AppImage based tools and this fix is the only thing that keeps dash-to-dock running. No sideeffects so far.
`Feb 05 17:39:07 ticktack gnome-shell[3912]: JS ERROR: TypeError: iconTexture.get_names is not a function
_getIconPixBuf@/home/tobias/.local/share/gnome-shell/extensions/[email protected]/appIconIndicators.js:941:61
_getColorPalette@/home/tobias/.local/share/gnome-shell/extensions/[email protected]/appIconIndicators.js:960:27
_enableBacklight@/home/tobias/.local/share/gnome-shell/extensions/[email protected]/appIconIndicators.js:216:57
update@/home/tobias/.local/share/gnome-shell/extensions/[email protected]/appIconIndicators.js:340:22
update@/home/tobias/.local/share/gnome-shell/extensions/[email protected]/appIconIndicators.js:102:23
_updateIndicatorStyle@/home/tobias/.local/share/gnome-shell/extensions/[email protected]/appIcons.js:181:25
_init@/home/tobias/.local/share/gnome-shell/extensions/[email protected]/appIcons.js:92:14
_createAppItem@/home/tobias/.local/share/gnome-shell/extensions/[email protected]/dash.js:479:23
_redisplay@/home/tobias/.local/share/gnome-shell/extensions/[email protected]/dash.js:809:36
_runDeferredWork@resource:///org/gnome/shell/ui/main.js:693:31
_runAllDeferredWork@resource:///org/gnome/shell/ui/main.js:702:25
queueDeferredWork/_deferredTimeoutId<@resource:///org/gnome/shell/ui/main.js:783:13