Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workaround for 'function iconTexture.get_names does not exist' #1385

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

workaround for 'function iconTexture.get_names does not exist' #1385

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions appIconIndicators.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -938,11 +938,14 @@ var DominantColorExtractor = class DashToDock_DominantColorExtractor {
}

// Get the pixel buffer from the icon theme
let icon_info = themeLoader.lookup_icon(iconTexture.get_names()[0], DOMINANT_COLOR_ICON_SIZE, 0);
if (icon_info !== null)
return icon_info.load_icon();
else
return null;
// sometime function iconTexture.get_names does not exist: JS ERROR: TypeError: iconTexture.get_names is not a function
if (iconTexture.get_names) {
let icon_info = themeLoader.lookup_icon(iconTexture.get_names()[0], DOMINANT_COLOR_ICON_SIZE, 0);
if (icon_info !== null)
return icon_info.load_icon();
else
return null;
}
Comment on lines +941 to +948
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can just early:

if (!iconTexture.get_names)
    return null;

}

/**
Expand Down