Fix registry cache broken #2715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 1, 2024 23:42
… returned by get function may lead to other routine set a changed services to cache
… returned by get function may lead to other routine set a changed services to cache
butonic
pushed a commit
to butonic/go-micro
that referenced
this pull request
Oct 28, 2024
* services is shared between routines, when application change services returned by get function may lead to other routine set a changed services to cache * services is shared between routines, when application change services returned by get function may lead to other routine set a changed services to cache --------- Co-authored-by: Shuaihu Liu <[email protected]>
butonic
pushed a commit
to butonic/go-micro
that referenced
this pull request
Oct 28, 2024
* services is shared between routines, when application change services returned by get function may lead to other routine set a changed services to cache * services is shared between routines, when application change services returned by get function may lead to other routine set a changed services to cache --------- Co-authored-by: Shuaihu Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
services varable here may be shared by routines, when application changes services returned by get function may lead to other routine set a changed services to cache. （which has happened on our live evn）
we need make sure services set to cache is what we get from registry by return the copy