-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom-alpha from 2.11.0-alpha to 2.12.0-alpha #946
Conversation
@dependabot rebase |
ecbedd2
to
0bf1920
Compare
@dependabot rebase |
0bf1920
to
5395c1c
Compare
@dependabot rebase |
5395c1c
to
7831e90
Compare
@dependabot rebase |
7831e90
to
00079af
Compare
@dependabot rebase |
…om-alpha Bumps [io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom-alpha](https://github.com/open-telemetry/opentelemetry-java-instrumentation) from 2.11.0-alpha to 2.12.0-alpha. - [Release notes](https://github.com/open-telemetry/opentelemetry-java-instrumentation/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/CHANGELOG.md) - [Commits](https://github.com/open-telemetry/opentelemetry-java-instrumentation/commits) --- updated-dependencies: - dependency-name: io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom-alpha dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
00079af
to
e99a201
Compare
@@ -9,7 +9,7 @@ aopalliance="1.0" | |||
zipkinAws="1.2.5" | |||
logback = "1.5.16" | |||
wavefrontSdk="3.4.3" | |||
otelInstrumentationBomAlpha="2.11.0-alpha" # Brings in io.opentelemetry:opentelemetry-bom:1.44.1 | |||
otelInstrumentationBomAlpha="2.12.0-alpha" # Brings in io.opentelemetry:opentelemetry-bom:1.44.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unfortunately an instance that requires manual updating. The comment should be updated to say 1.45.0
per the release notes:
This release targets the OpenTelemetry SDK 1.45.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could exclude the BOM ? Then we could have a direct dependency on opentelemetry-bom as such?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We used to depend on different artifacts with different versioning and we ended-up having conflicts:
So instead of depending on multiple versions, we moved to a single source of truth (BOM). Unfortunately this BOM has another issue: its patch version upgrades contain minor version upgrades, see: #823
We need to manually check this, hence the comment.
Another alternative I guess is removing the comment and not upgrading OTel in patch versions.
Bumps io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom-alpha from 2.11.0-alpha to 2.12.0-alpha.
Release notes
Sourced from io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom-alpha's releases.
... (truncated)
Changelog
Sourced from io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom-alpha's changelog.
... (truncated)
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)