Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom-alpha from 2.11.0-alpha to 2.12.0-alpha #946

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 17, 2025

Bumps io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom-alpha from 2.11.0-alpha to 2.12.0-alpha.

Release notes

Sourced from io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom-alpha's releases.

Version 2.11.0

This release targets the OpenTelemetry SDK 1.45.0.

Note that many artifacts have the -alpha suffix attached to their version number, reflecting that they are still alpha quality and will continue to have breaking changes. Please see the VERSIONING.md for more details.

Migration notes

In preparation for stabilizing HTTP library instrumentation soon:

  • addAttributeExtractor methods in a few *TelemetryBuilder classes have been deprecated and renamed to addAttributesExtractor (which is how most of them were named already) (#12860)
  • setEmitExperimental* methods in *TelemetryBuilder classes have been deprecated and moved to internal/experimental classes, see Javadoc @deprecated for exact relocation (#12847)
  • ApacheHttpClient5* classes have been deprecated and renamed to ApacheHttpClient* (#12854)
  • RatpackTelemetry* classes have been deprecated and split into RatpackClientTelemetry* and RatpackServerTelemetry* (#12853)
  • SpringWebfluxTelemetry* classes have been deprecated and split into SpringWebfluxClientTelemetry* and SpringWebfluxServerTelemetry* (#12852)
  • ArmeriaTelemetry* classes have been deprecated and split into ArmeriaClientTelemetry* and ArmeriaServerTelemetry* (#12851)
  • *KtorClientTracing* and *KtorServerTracing* have been deprecated and renamed to *KtorClientTelemetry* and *KtorServerTelemetry* (#12855)
  • Experimental opt-in attribute spring-webflux.handler.type was removed in favor of standard code.* attributes (#12887)

📈 Enhancements

  • Map lettuce 5.1 db.namespace to db.name (unless using experimental database semconv stability opt-in) (#12609)
  • Log4j2: add option to fill code attributes (#12592)
  • Fill jvm.thread.state attribute for jvm.thread.count metric on jdk8 (#12724)
  • Update Spring Scheduling code.* attribute extraction for latest release of Spring Scheduling (#12739)
  • Add jctools classes to reflect-config.json for better native image support (#12736)
  • Support Pulsar Client send message with transaction (#12731)
  • Implement reading of simple key-value Logstash JSON Marker attributes (#12513)
  • Add agent instrumentation for Ratpack 1.7+ (#12572)
  • Added spring-scheduling.enabled property to spring-configuration-metadata.json (#12791)
  • Remove class files from spring-boot-autoconfigure source jar (#12798)
  • Updated Camel rules adding route.started, route.added, and thread pools' pool.core_size (#12763)
  • Add database client metrics (when using experimental database semconv stability opt-in) (#12806, #12818)
  • Add dynamodb instrumenter for aws v1_11 sdk (#12756)
  • Remove public suffixes list from the agent (#10763)
  • Add an option to disable automatic kafka interceptor configuration in spring starter (#12833)
  • Add code attributes to spring webmvc controller spans (#12839)
  • Hibernate 6: don't record error on NoResultException (#12879)
  • Add support for missing spring list properties (#12819)
  • Ktor: support setting custom spanNameExtractor (#12842) (#12850)
  • Rename "db.client.connections.usage" to "db.client.connection.count" (when using experimental database semconv stability opt-in) (#12886)
  • Support Struts 7.0 (#12935)
  • Support latest Ktor release (#12937)

🛠️ Bug fixes

  • Logback: don't make MDCPropertyMap of logging event immutable (#12718)
  • Avoid exception when redisson address is null (#12883)
  • Add close to fix CWE-404 (#12908)

🙇 Thank you

... (truncated)

Changelog

Sourced from io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom-alpha's changelog.

Changelog

Unreleased

Version 2.12.0 (2025-01-17)

Migration notes

  • Some Java agent instrumentation suppression keys have been renamed to match their module names:
    • elasticsearch-rest-6.0 --> elasticsearch-rest-6.4
    • internal-application-logging --> internal-application-logger
    • javalin-5 -> javalin-5.0
    • pulsar-2.8.0 -> pulsar-2.8
  • In preparation for stabilizing HTTP library instrumentation soon:
    • setCaptured*Headers(List) methods in *TelemetryBuilder classes were changed to setCaptured*Headers(Collection) (#12901)
    • setKnownMethods(Set) methods in *TelemetryBuilder classes were changed to setKnownMethods(Collection) (#12902)

📈 Enhancements

  • Support ExtendedTextMapGetter in gRPC instrumentation (#13011)
  • Add database client metrics in DynamoDB instrumentation (#13033)
  • Propagate context into async http client CompletableFuture callbacks (#13041)
  • Exclude spring routing data source from Spring Starter instrumentation (#13054)
  • Instrument jdbc batch queries (#12797)

🛠️ Bug fixes

  • Fix incorrect dubbo trace caused by using rpcContext.isProviderSide() (#12930)
  • Fix ClickHouse query failing with syntax error (#13020)
  • Fix instrumentation module not loading silently when duplicate helper classnames are detected (#13005)
  • Fix compatibility problem due to DubboHeadersGetter#keys in Dubbo 2.7.6 and 2.7.7 (#12982)
  • Fix appender install for async Logback appenders (#13047)

Version 2.11.0 (2024-12-23)

Migration notes

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependency-upgrade A dependency upgrade java Pull requests that update Java code labels Jan 17, 2025
@dependabot dependabot bot added this to the 1.x milestone Jan 17, 2025
@marcingrzejszczak
Copy link
Contributor

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/gradle/main/io.opentelemetry.instrumentation-opentelemetry-instrumentation-bom-alpha-2.12.0-alpha branch from ecbedd2 to 0bf1920 Compare January 17, 2025 15:06
@marcingrzejszczak
Copy link
Contributor

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/gradle/main/io.opentelemetry.instrumentation-opentelemetry-instrumentation-bom-alpha-2.12.0-alpha branch from 0bf1920 to 5395c1c Compare January 17, 2025 15:10
@marcingrzejszczak
Copy link
Contributor

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/gradle/main/io.opentelemetry.instrumentation-opentelemetry-instrumentation-bom-alpha-2.12.0-alpha branch from 5395c1c to 7831e90 Compare January 17, 2025 15:28
@marcingrzejszczak
Copy link
Contributor

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/gradle/main/io.opentelemetry.instrumentation-opentelemetry-instrumentation-bom-alpha-2.12.0-alpha branch from 7831e90 to 00079af Compare January 17, 2025 15:38
@marcingrzejszczak
Copy link
Contributor

@dependabot rebase

…om-alpha

Bumps [io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom-alpha](https://github.com/open-telemetry/opentelemetry-java-instrumentation) from 2.11.0-alpha to 2.12.0-alpha.
- [Release notes](https://github.com/open-telemetry/opentelemetry-java-instrumentation/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/CHANGELOG.md)
- [Commits](https://github.com/open-telemetry/opentelemetry-java-instrumentation/commits)

---
updated-dependencies:
- dependency-name: io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom-alpha
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/gradle/main/io.opentelemetry.instrumentation-opentelemetry-instrumentation-bom-alpha-2.12.0-alpha branch from 00079af to e99a201 Compare January 17, 2025 15:53
@github-actions github-actions bot modified the milestones: 1.x, 1.3.9 Jan 17, 2025
@github-actions github-actions bot merged commit 22fa2cd into main Jan 17, 2025
4 of 8 checks passed
@dependabot dependabot bot deleted the dependabot/gradle/main/io.opentelemetry.instrumentation-opentelemetry-instrumentation-bom-alpha-2.12.0-alpha branch January 17, 2025 15:53
@marcingrzejszczak marcingrzejszczak modified the milestones: 1.3.9, 1.5.0-M2 Jan 17, 2025
@@ -9,7 +9,7 @@ aopalliance="1.0"
zipkinAws="1.2.5"
logback = "1.5.16"
wavefrontSdk="3.4.3"
otelInstrumentationBomAlpha="2.11.0-alpha" # Brings in io.opentelemetry:opentelemetry-bom:1.44.1
otelInstrumentationBomAlpha="2.12.0-alpha" # Brings in io.opentelemetry:opentelemetry-bom:1.44.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unfortunately an instance that requires manual updating. The comment should be updated to say 1.45.0 per the release notes:

This release targets the OpenTelemetry SDK 1.45.0.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could exclude the BOM ? Then we could have a direct dependency on opentelemetry-bom as such?

Copy link
Member

@jonatan-ivanov jonatan-ivanov Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We used to depend on different artifacts with different versioning and we ended-up having conflicts:

So instead of depending on multiple versions, we moved to a single source of truth (BOM). Unfortunately this BOM has another issue: its patch version upgrades contain minor version upgrades, see: #823
We need to manually check this, hence the comment.

Another alternative I guess is removing the comment and not upgrading OTel in patch versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency-upgrade A dependency upgrade java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants