Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom-alpha from 2.11.0-alpha to 2.12.0-alpha #946

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Bump io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom-alpha from 2.11.0-alpha to 2.12.0-alpha #946

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ aopalliance="1.0"
zipkinAws="1.2.5"
logback = "1.5.16"
wavefrontSdk="3.4.3"
otelInstrumentationBomAlpha="2.11.0-alpha" # Brings in io.opentelemetry:opentelemetry-bom:1.44.1
otelInstrumentationBomAlpha="2.12.0-alpha" # Brings in io.opentelemetry:opentelemetry-bom:1.44.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unfortunately an instance that requires manual updating. The comment should be updated to say 1.45.0 per the release notes:

This release targets the OpenTelemetry SDK 1.45.0.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could exclude the BOM ? Then we could have a direct dependency on opentelemetry-bom as such?

Copy link
Member

@jonatan-ivanov jonatan-ivanov Jan 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We used to depend on different artifacts with different versioning and we ended-up having conflicts:

So instead of depending on multiple versions, we moved to a single source of truth (BOM). Unfortunately this BOM has another issue: its patch version upgrades contain minor version upgrades, see: #823
We need to manually check this, hence the comment.

Another alternative I guess is removing the comment and not upgrading OTel in patch versions.

log4j = "2.24.3"
wavefrontReporter="1.7.16"
slf4j = "1.7.36"
Expand Down
Loading