Skip to content

Commit

Permalink
feat(client-debugger): Change audienceID to userID (#15601)
Browse files Browse the repository at this point in the history
#### Description

Change `Devtools`'s `Audience ID` to `User ID`. 


#### Related PR

#15431
  • Loading branch information
jikim-msft authored May 17, 2023
1 parent 94ac51f commit a182e25
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -155,12 +155,12 @@ export namespace ContainerStateHistory {
export interface ContainerStateMetadata extends ContainerMetadata {
// (undocumented)
attachState: AttachState;
audienceId?: string;
// (undocumented)
clientId?: string;
closed: boolean;
// (undocumented)
connectionState: ConnectionState;
userId?: string;
}

// @internal
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -579,8 +579,7 @@ export class ContainerDevtools implements IContainerDevtools {
connectionState: this.container.connectionState,
closed: this.container.closed,
clientId: this.container.clientId,
audienceId:
clientId === undefined ? undefined : this.audience.getMember(clientId)?.user.id,
userId: clientId === undefined ? undefined : this.audience.getMember(clientId)?.user.id,
};
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,5 +62,5 @@ export interface ContainerStateMetadata extends ContainerMetadata {
*
* @remarks Will be undefined when the Container is not connected.
*/
audienceId?: string;
userId?: string;
}
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ export function ContainerSummaryView(props: ContainerSummaryViewProps): React.Re
{DataRow("Container", containerState.id, columnSizing_unstable)}
{ContainerStatusRow(statusComponents)}
{DataRow("Client ID", containerState.clientId, columnSizing_unstable)}
{DataRow("Audience ID", containerState.audienceId, columnSizing_unstable)}
{DataRow("User ID", containerState.userId, columnSizing_unstable)}
</Table>
</StackItem>
<StackItem align="start">
Expand Down

0 comments on commit a182e25

Please sign in to comment.