Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FF client Buffer error under browser #21252

Closed
huntj88 opened this issue May 29, 2024 · 1 comment
Closed

FF client Buffer error under browser #21252

huntj88 opened this issue May 29, 2024 · 1 comment
Assignees
@DLehenbauer
Labels
bug Something isn't working resolution: fixed For issues that have been fixed

Comments

@huntj88
Copy link

huntj88 commented May 29, 2024 •
edited
Loading

Describe the bug

Version with bug: 2.0.0-rc.4.0.1
This bug does not happen on 2.0.0-rc.2.0.1

Manual step to fix locally at bottom.

image

To Reproduce

  1. clone Live Share SDK from https://github.com/microsoft/live-share-sdk
  2. check out commit 1956dff6e5126b10768858d27d15f7a32e639107
  3. navigate to sample samples/typescript/08.3d-model
  4. npm install
  5. npm run start
  6. navigate to http://localhost:3000/ in browser
  7. see blank screen, with error in console

Steps to reproduce the behavior:

Expected behavior

App should work.

Manual steps required to fix locally

change file node_modules/@fluid-internal/client-utils/lib/trace.js

from:

import { performance } from "./indexNode.js";

to:

import { performance } from "./performanceIsomorphic.js";
@huntj88 huntj88 added the bug Something isn't working label May 29, 2024
@tylerbutler tylerbutler mentioned this issue May 29, 2024
Merged
@jason-ha jason-ha changed the title Tinylicious Buffer error FF client Buffer error under browser May 29, 2024
@DLehenbauer DLehenbauer mentioned this issue May 30, 2024
Merged
DLehenbauer added a commit that referenced this issue Jun 4, 2024
@DLehenbauer @jason-ha
fix(client-utils): fix trace.js import of performance (#21257)
925a477 
Fix GH #21252

---------

Co-authored-by: Jason Hartman <[email protected]>
scottn12 added a commit to scottn12/FluidFramework that referenced this issue Jun 5, 2024
@scottn12 @jason-ha
fix(client-utils): fix trace.js import of performance (microsoft#21257)
76b9e39 
Fix GH microsoft#21252

---------

Co-authored-by: Jason Hartman <[email protected]>
@scottn12 scottn12 mentioned this issue Jun 5, 2024
Closed
scottn12 pushed a commit to scottn12/FluidFramework that referenced this issue Jun 5, 2024
@DLehenbauer @jason-ha @scottn12
fix(client-utils): fix trace.js import of performance (microsoft#21257)
23d760e 
Fix GH microsoft#21252

---------

Co-authored-by: Jason Hartman <[email protected]>
@scottn12 scottn12 mentioned this issue Jun 5, 2024
Merged
scottn12 pushed a commit to scottn12/FluidFramework that referenced this issue Jun 5, 2024
@DLehenbauer @jason-ha @scottn12
fix(client-utils): fix trace.js import of performance (microsoft#21257)
cf8bc68 
Fix GH microsoft#21252

---------

Co-authored-by: Jason Hartman <[email protected]>
scottn12 added a commit that referenced this issue Jun 5, 2024
@scottn12 @DLehenbauer @jason-ha
fix(client-utils): fix node/browser dependent support (#21321)
0425c06 
Fix GH #21252

Cherry pick of
44da14a
&
925a477

---------

Co-authored-by: Daniel Lehenbauer <[email protected]>
Co-authored-by: Jason Hartman <[email protected]>
scottn12 pushed a commit to scottn12/FluidFramework that referenced this issue Jun 5, 2024
@DLehenbauer @jason-ha @scottn12
fix(client-utils): fix trace.js import of performance (microsoft#21257)
11f1b0b 
Fix GH microsoft#21252

---------

Co-authored-by: Jason Hartman <[email protected]>
@scottn12 scottn12 mentioned this issue Jun 5, 2024
Merged
scottn12 pushed a commit to scottn12/FluidFramework that referenced this issue Jun 5, 2024
@DLehenbauer @jason-ha @scottn12
fix(client-utils): fix trace.js import of performance (microsoft#21257)
f91bb17 
Fix GH microsoft#21252

---------

Co-authored-by: Jason Hartman <[email protected]>
@scottn12 scottn12 mentioned this issue Jun 5, 2024
Merged
scottn12 added a commit that referenced this issue Jun 5, 2024
@scottn12 @DLehenbauer @jason-ha
fix(client-utils): fix trace.js import of performance (#21257) (#21322)
d02a5e9 
Fix GH #21252

Cherry pick of
925a477

Co-authored-by: Daniel Lehenbauer <[email protected]>
Co-authored-by: Jason Hartman <[email protected]>
scottn12 added a commit that referenced this issue Jun 5, 2024
@scottn12 @DLehenbauer @jason-ha
fix(client-utils): fix trace.js import of performance (#21257) (#21323)
28d581b 
Fix GH #21252

Cherry pick of
925a477

Co-authored-by: Daniel Lehenbauer <[email protected]>
Co-authored-by: Jason Hartman <[email protected]>
@tylerbutler tylerbutler added the resolution: fixed For issues that have been fixed label Jun 21, 2024
@tylerbutler
Copy link
Member

This was fixed by #21257, which was released in 2.0.0-rc.3.0.7 and 2.0.0-rc.4.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DLehenbauer DLehenbauer

Labels
bug Something isn't working resolution: fixed For issues that have been fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tylerbutler @huntj88 @DLehenbauer @jason-ha