Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client-utils): fix node/browser dependent support #21321

Merged

Conversation

scottn12
Copy link
Contributor

@scottn12 scottn12 commented Jun 5, 2024

Fix GH #21252

Cherry pick of 44da14a & 925a477

DLehenbauer and others added 2 commits June 5, 2024 16:16
…soft#20665)

Previously, we used [the 'browser'
field](https://github.com/defunctzombie/package-browser-field-spec) to
implement different entry points for browser vs. node.

This field does not appear to be supported by CloudPack. Instead, we now
use [conditional
exports](https://nodejs.org/docs/latest-v18.x/api/packages.html#conditional-exports)
in the export map.
@jason-ha jason-ha changed the title fix(client-utils): fix trace.js import of performance fix(client-utils): fix node/browser dependent support Jun 5, 2024
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Jun 5, 2024

Could not find a usable baseline build with search starting at CI 1a00982

Generated by 🚫 dangerJS against 84476e5

@scottn12 scottn12 marked this pull request as ready for review June 5, 2024 20:58
@scottn12 scottn12 requested review from DLehenbauer and jason-ha June 5, 2024 20:58
packages/common/client-utils/bufferBrowser.d.ts Outdated Show resolved Hide resolved
@scottn12 scottn12 merged commit 0425c06 into microsoft:release/client/2.0.0-rc.2.0 Jun 5, 2024
27 checks passed
@scottn12 scottn12 deleted the fixTraceJs2 branch June 5, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants