FIX : Handle checkpoint error and proceed with remaining ops deletion batch #20576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: server
|
@tylerbutler @anthony-murphy |
|
@arafat-java the command you issued was incorrect. Please try again. Examples are: and |
arafat-java
force-pushed
the
handle-checkpoint-fetch-issue
branch
from
0bf4099 to
f002c59
Compare
|
This PR fixes #20629 |
arafat-java
changed the title
zhangxin511
approved these changes
Apr 17, 2024
| @@ -45,6 +45,14 @@ export async function deleteSummarizedOps( | |||
| doc.documentId, | |||
| ); | |||
|
|
|||
| if (realDoc === null) { | |||
There was a problem hiding this comment.
should work for this. But maybe we can do something even safer like:
const lastSummarySequenceNumber = JSON.parse(realDoc?.scribe ?? "{}")?.lastSummarySequenceNumber
if (lastSummarySequenceNumber === undefined) }
Lumberjack.error(
`Unable to delete ops. Reason: ....`,
lumberjackProperties,
);
continue;
}
|
@nmsimons , @CraigMacomber , @tylerbutler |
arafat-java
added a commit
to arafat-java/FluidFramework
that referenced
this pull request
Apr 25, 2024
… batch (microsoft#20576) ## Description Presently when using the deleteSummarizedOps.ts when the aggregated data regarding all the unique documentIds is passed, the process iterates through each of those and then adds soft delete markers to deltas (where applicable) and does hard delete of deltas (where applicable). And this is done in a sequential manner for each of the documents which are passed in. Now the issue is whenever there is an error occurring for any of the documents, all the documents there after are not handled and the loop breaks in between Ideally the error should be logged for the document for which the failure happens and all the subsequent documents deletion should take place This commit intends to handle the checkpoint fetch error for specific documents gracefully, log the details of that document and proceed with processing rest of the batch
This was referenced Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Presently when using the deleteSummarizedOps.ts when the aggregated data regarding all the unique documentIds is passed, the process iterates through each of those and then adds soft delete markers to deltas (where applicable) and does hard delete of deltas (where applicable). And this is done in a sequential manner for each of the documents which are passed in.
Now the issue is whenever there is an error occurring for any of the documents, all the documents there after are not handled and the loop breaks in between
Ideally the error should be logged for the document for which the failure happens and all the subsequent documents deletion should take place
This commit intends to handle the checkpoint fetch error for specific documents gracefully, log the details of that document and proceed with processing rest of the batch