Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX : Handle checkpoint error and proceed with remaining ops deletion batch #20576

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -45,6 +45,14 @@ export async function deleteSummarizedOps(
doc.documentId,
);

if (realDoc === null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should work for this. But maybe we can do something even safer like:

const lastSummarySequenceNumber = JSON.parse(realDoc?.scribe ?? "{}")?.lastSummarySequenceNumber
if (lastSummarySequenceNumber === undefined) }
          Lumberjack.error(
					`Unable to delete ops. Reason: ....`,
					lumberjackProperties,
				);
				continue;
}

Lumberjack.error(
`Unable to delete ops. Reason: Failed to get latest checkpoint`,
lumberjackProperties,
);
continue;
}

const lastSummarySequenceNumber = JSON.parse(realDoc.scribe).lastSummarySequenceNumber;

// first "soft delete" operations older than the offline window, which have been summarised
@@ -84,7 +92,6 @@ export async function deleteSummarizedOps(
}
} catch (error) {
Lumberjack.error(`Error while trying to delete ops`, lumberjackProperties, error);
throw error;
}
}
}