-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pcl] When cross-compiling pcl for Android pre-set some cache variables. #41506
Conversation
…MM_MALLOC and HAVE_POSIX_MEMALIGN
@microsoft-github-policy-service agree |
Co-authored-by: Kai Pastor <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain what the effect of setting these is, and why it is correct to do so for Android?
Sorry for the delay in answering this. The problem this fix solves is that these build-time tests depend on running a program to test the existence of some aligned-allocation functions. This cannot work when cross-compiling. When building for Android you're always cross-compiling. Moreover, these macros aren't actually needed because they're used in one place in the pcl sources, and in that place there's a separate I've reported the same issue in the pcl repo, but past experience suggests that the pcl developers move at glacial speed. |
Co-authored-by: Billy O'Neal <[email protected]>
Superseded by #43295 |
Fixes #41505.
./vcpkg x-add-version --all
and committing the result.