Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pcl] When cross-compiling pcl for Android pre-set some cache variables. #41506

Closed

Conversation

jackjansen
Copy link

@jackjansen jackjansen commented Oct 11, 2024

Fixes #41505.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@jackjansen
Copy link
Author

@jackjansen please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@jimwang118 jimwang118 added the category:port-bug The issue is with a library, which is something the port should already support label Oct 12, 2024
ports/pcl/portfile.cmake Outdated Show resolved Hide resolved
@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Oct 15, 2024
@jimwang118 jimwang118 changed the title When cross-compiling pcl for Android pre-set some cache variables. Fixes #41505 [pcl] When cross-compiling pcl for Android pre-set some cache variables. Oct 15, 2024
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain what the effect of setting these is, and why it is correct to do so for Android?

ports/pcl/portfile.cmake Outdated Show resolved Hide resolved
@data-queue data-queue removed the info:reviewed Pull Request changes follow basic guidelines label Oct 21, 2024
@data-queue data-queue marked this pull request as draft October 21, 2024 22:28
@jackjansen
Copy link
Author

Sorry for the delay in answering this.

The problem this fix solves is that these build-time tests depend on running a program to test the existence of some aligned-allocation functions. This cannot work when cross-compiling.

When building for Android you're always cross-compiling. Moreover, these macros aren't actually needed because they're used in one place in the pcl sources, and in that place there's a separate #if for Android.

I've reported the same issue in the pcl repo, but past experience suggests that the pcl developers move at glacial speed.

@jackjansen
Copy link
Author

Superseded by #43295

@jackjansen jackjansen closed this Jan 15, 2025
@jackjansen jackjansen deleted the pcl-android-crosscompile branch January 15, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pcl] build failure when cross-compiling for Android
5 participants