Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pcl] Fix pcl build when building for arm/arm64 #43295

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jackjansen
Copy link

Fixes #41505.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Supersedes the older pull request #41506.

The change is simple: Pass -DPCL_ENABLE_SSE=OFF to cmake when building for arm64 or arm. This forestalls the attempt to run the cmake configuration scripts that try to determine the SSE features. They would all return false anyway because SSE is x86-only.

@jimwang118 jimwang118 changed the title Fix pcl build when building for arm/arm64 [pcl] Fix pcl build when building for arm/arm64 Jan 16, 2025
@jimwang118 jimwang118 added the category:port-bug The issue is with a library, which is something the port should already support label Jan 16, 2025
@jimwang118
Copy link
Contributor

jimwang118 commented Jan 16, 2025

You need to delete pcl:arm-neon-android=fail, pcl:arm64-android=fail in the ci.baseline.txt file.

@jimwang118
Copy link
Contributor

Compile test pass with following triplets:

arm-neon-android
arm64-android

@jimwang118 jimwang118 marked this pull request as draft January 16, 2025 08:00
@jackjansen jackjansen marked this pull request as ready for review January 18, 2025 16:20
@jackjansen
Copy link
Author

The three failure have nothing to do with pcl: they seem to be in libmem (which I haven't touched and don't even know).
Please advise on what I should do about this, if anything.

@frenchcore23
Copy link

frenchcore23 commented Jan 18, 2025 via email

@jackjansen
Copy link
Author

@frenchcore23 I was referring to the failures in the automated tests. The three failures (x64_windows, x64_windows_static and x64_windows_static_md) have nothing to do with the pcl changes that I made in this pull request. I have absolutely no idea what I should do to get these.

I was hoping that @jimwang118 would guide me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pcl] build failure when cross-compiling for Android
3 participants