Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typing for lights in Scene.__init__ #2162

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

maitbayev
Copy link
Contributor

lights should be Optional[List[lighting.Light]] instead of Optional[lighting.Light]

@maitbayev
Copy link
Contributor Author

cc @mikedh

@mikedh mikedh changed the base branch from main to feat/typeguard February 26, 2024 03:53
@mikedh mikedh merged commit 1b90e7f into mikedh:feat/typeguard Feb 26, 2024
9 checks passed
@mikedh
Copy link
Owner

mikedh commented Feb 26, 2024

Thanks for the fix!! I added typeguard to check this in the future, which caught a bunch of other instances. I didn't do the whole module, but if anyone else wants to contribute typing fixes if you run tests with typeguard it catches a lot more of them:

pytest --typeguard-packages=trimesh tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants