Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CLI utilities into internal/util/cli from internal/util to balance tests #5386

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

evankanderson
Copy link
Member

Summary

I saw timeouts on internal/util tests, possibly due to recently-merged #4651 increasing the total set of tests in internal/util by a fair amount to hit the 10m limit.

This PR moves a bunch of those new tests into internal/cli, along with the implementation (which is only used by the CLI, and not Minder server).

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Ran unit tests locally.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

JAORMX
JAORMX previously approved these changes Jan 30, 2025
Copy link
Contributor

@JAORMX JAORMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sensible

@eleftherias
Copy link
Contributor

I'm not sure why the tests are failing here, I ran them locally and they passed

@JAORMX
Copy link
Contributor

JAORMX commented Jan 30, 2025

Solar flares

teodor-yanev
teodor-yanev previously approved these changes Jan 30, 2025
@evankanderson
Copy link
Member Author

There seems to be some variance in performance on the GitHub workers -- sometimes they take 11 minutes and everything is fine, and sometimes they take ~17 minutes, and time out.

@evankanderson evankanderson dismissed stale reviews from teodor-yanev and JAORMX via 9a90f47 January 30, 2025 14:19
@coveralls
Copy link

Coverage Status

coverage: 57.404% (+0.003%) from 57.401%
when pulling e08bc1e on evankanderson:move-cli-util
into fc18f0f on mindersec:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review
Development

Successfully merging this pull request may close these issues.

5 participants