Capture transparent hugepages config in health report #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anjalshireesh
changed the title
anjalshireesh
force-pushed
the
health
branch
2 times, most recently
from
f5ed233 to
fab6025
Compare
vadmeste
reviewed
Jan 2, 2024
There was a problem hiding this comment.
@anjalshireesh maybe we can make this structure more generic; there are a lot of entries under '/sys/kernel/mm/transparent_hugepage/' and I think we may need all of them in the future. It shouldn't hurt to have a generic structure to contain many entries.
@vadmeste have changed it to |
klauspost
reviewed
Jan 5, 2024
harshavardhana
approved these changes
Jan 18, 2024
Add a new node `thp-config` under `sys -> config` and inside it add values from following config files: /sys/kernel/mm/transparent_hugepage/enabled /sys/kernel/mm/transparent_hugepage/defrag /sys/kernel/mm/transparent_hugepage/khugepaged/max_ptes_none ref: https://tip.golang.org/doc/gc-guide#Linux_transparent_huge_pages
shtripat
reviewed
Jan 19, 2024
Co-authored-by: Shubhendu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new node
thp-configundersys -> configand inside it add values from following config files:/sys/kernel/mm/transparent_hugepage/enabled
/sys/kernel/mm/transparent_hugepage/defrag
/sys/kernel/mm/transparent_hugepage/khugepaged/max_ptes_none
ref: https://tip.golang.org/doc/gc-guide#Linux_transparent_huge_pages