Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSV exports #1020

Merged
merged 5 commits into from
Nov 8, 2024
Merged

CSV exports #1020

merged 5 commits into from
Nov 8, 2024
+308 −51

Conversation

MatMoore
Copy link
Contributor

@MatMoore MatMoore commented Nov 7, 2024 •
edited
Loading

Add buttons to export metadata as CSV, where we present it in tables.

  • Table schema
  • List of tables in a database
  • List of charts in a dashboard

Screenshot 2024-11-08 at 09 30 55

Questions for design review

  • Is it worth moving the button closer to the data table?
  • Does the copy make sense?

@MatMoore
refactor: remove wrapper functions for services
1302c2e 
In the details view, expose the service object directly.

This will make it easier to add CSV representations.
@MatMoore MatMoore force-pushed the fmj-661-csv-exports branch 4 times, most recently from d4b8c25 to 8475199 Compare November 8, 2024 09:30
@MatMoore
feat: add classes to generate table CSVs
4fccede
@MatMoore
feat: add button for csv downloads
c572030 
Use the secondary button style, as this is not a call to action, and
neither is it a link to another page.
@MatMoore
fixup: remove primary key from csv
efcf56c 
We don't show this in the UI because it's not populated reliably, so
we shouldn't included it in the csv either.
@MatMoore MatMoore force-pushed the fmj-661-csv-exports branch from 8475199 to efcf56c Compare November 8, 2024 10:16
@MatMoore MatMoore changed the title [WIP] CSV exports CSV exports Nov 8, 2024
@MatMoore MatMoore marked this pull request as ready for review November 8, 2024 10:16
@MatMoore MatMoore requested a review from a team as a code owner November 8, 2024 10:16
LavMatt
LavMatt reviewed Nov 8, 2024
View reviewed changes
Copy link
Contributor

@LavMatt LavMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Minor comment re. the content of the table csv not including nullable

home/service/details_csv.py Outdated Show resolved Hide resolved
home/service/details_csv.py Outdated Show resolved Hide resolved
@MatMoore MatMoore merged commit 4714de1 into main Nov 8, 2024
8 checks passed
@MatMoore MatMoore deleted the fmj-661-csv-exports branch November 8, 2024 13:49
@sentry-io Sentry.io
Copy link

sentry-io bot commented Nov 18, 2024 •
edited
Loading

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ValueError: year 56533 is out of range /details/{result_type}/{urn} View Issue
  • ‼️ InvalidUrnError: DatasetUrn should have 3 parts, got 1: ['(urn:li:dataPlatform:dbt,cadet.awsdatacatalog.nomis_dbt.... /details/{result_type}/{urn} View Issue
  • ‼️ GraphError: Error executing graphql query: [{'message': 'An unknown error occurred.', 'locations': [{'line': ... /details/{result_type}/{urn} View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LavMatt LavMatt LavMatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatMoore @LavMatt