Fix NavigationTest::testLinks on PHP 7.1 #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The last commit proves that
is correct. Very very odd. |
|
https://github.com/marketplace/actions/setup-php-action doesn't support patch versions so there's no new info from the last commit. |
|
@alexpott I suggest giving up on this one, as you don't find a way to avoid the segfault on PHP 7.1 |
|
When working on #304, I've faced same issue with 7.1. I've fixed this issue by adding USE_ZEND_ALLOC=0 |
|
@oleg-andreyev thanks! Works like a treat - nice one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a segfault that occurs on PHP 7.1 when date.timezone is not configured.
In testing this has not proved enough because another segfault occurs in \Behat\Mink\Tests\Driver\Form\GeneralTest::testBasicForm() after running NavigationTest::testLinks(). What's really odd is if you run them the other way around it works just fine.