Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NavigationTest::testLinks on PHP 7.1 #342

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Fix NavigationTest::testLinks on PHP 7.1 #342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ jobs:
coverage: "none"
php-version: "${{ matrix.php }}"
tools: composer
# PHP 7.1 development web server segfaults if timezone not set.
ini-values: date.timezone=Europe/Paris, error_reporting=-1, display_errors=On

- name: Configure for PHP >= 7.1
if: "${{ matrix.php >= '7.1' }}"
Expand All @@ -46,8 +48,10 @@ jobs:
composer update --no-interaction --prefer-dist

- name: Setup Mink test server
# PHP 7.1 development web server segfaults if USE_ZEND_ALLOC not set to 0.
run: |
mkdir ./logs
export USE_ZEND_ALLOC=0
./vendor/bin/mink-test-server &> ./logs/mink-test-server.log &

- name: Start Selenium
Expand Down
9 changes: 0 additions & 9 deletions tests/Selenium2Config.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,6 @@ public function skipMessage($testCase, $test)
return 'Maximizing the window does not work when running the browser in Xvfb.';
}

if (
'Behat\Mink\Tests\Driver\Basic\NavigationTest' === $testCase
&& (0 === strpos($test, 'testLinks'))
&& 'true' === getenv('GITHUB_ACTIONS')
&& '7.1' === getenv('MATRIX_PHP')
) {
return 'Skipping basic NavigationTest::testLinks on PHP 7.1';
}

return parent::skipMessage($testCase, $test);
}

Expand Down