-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Version 3] Add CPU load tracking #316
base: master
Are you sure you want to change the base?
Conversation
37faa92
to
d541335
Compare
Will close #333 |
208d5ff
to
2054668
Compare
Here is how to test:
If you have RAPL, the log will display a comparison between RAPL and the new estimation based on CPU load:
|
@@ -303,10 +303,7 @@ def __init__( | |||
hardware = CPU.from_utils(self._output_dir, "intel_rapl") | |||
self._hardware.append(hardware) | |||
self._conf["cpu_model"] = hardware.get_model() | |||
else: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I arrived to this case. (Testing with Windows machine, but unfortunately I do not have RAPL in this machine and the Intel Power Gadget is not even installed, see #457).
Why remove this else
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for testing both mode.
Is the "Test under Linux with RAPL" done? @benoit-cty |
Yes, it's the only one that works for sure. |
96976f8
to
efcee54
Compare
When none of RAPL or PowerGadget is available, the mode will use CPU load to estimate the CPU Power.
How to test:
To check if it's working :
CPU load 180 W x 90.9% = 163.62 for whole machine.
If you want to monitor only your process:
TODO: