New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rust interface to untrusted SGX #2

Merged

nick-mobilecoin merged 1 commit into develop from feature/untrusted

Jul 20, 2022

Collaborator

nick-mobilecoin commented May 5, 2022 •

edited

Loading

Add a rust interface for the untrusted side of the SGX interface. This
provides the capability to create enclaves and call into them.

This is bigger than I wanted it to be, but I wanted to have working tests that show the rust wrapper actually works.
Up for suggestions on how this can be broken up more.

This place the untrusted interface down in a lower directory as its own cargo workspace, this to let it use the host target triple while the upcoming trusted side will utilize a custom target triple.

This was not played on top of the develop branch to minimize the already significant changes

nick-mobilecoin requested review from jcape, NotGyro, remoun and a team

May 5, 2022 16:00

remoun reviewed

View reviewed changes

untrusted/Cargo.toml Outdated Show resolved Hide resolved

untrusted/build.rs Outdated Show resolved Hide resolved

untrusted/build.rs Outdated Show resolved Hide resolved

untrusted/src/lib.rs Outdated Show resolved Hide resolved

untrusted/test_enclave/README.md Outdated Show resolved Hide resolved

untrusted/test_enclave/build.rs Outdated Show resolved Hide resolved

untrusted/test_enclave/build.rs Outdated Show resolved Hide resolved

untrusted/test_enclave/build.rs Outdated Show resolved Hide resolved

untrusted/test_enclave/build.rs Outdated Show resolved Hide resolved

untrusted/test_enclave/src/lib.rs Outdated Show resolved Hide resolved

remoun requested a review from a team

May 5, 2022 17:06

jcape reviewed

View reviewed changes

untrusted/build.rs Outdated Show resolved Hide resolved

jcape suggested changes

View reviewed changes

untrusted/src/lib.rs Outdated Show resolved Hide resolved

untrusted/src/lib.rs Outdated Show resolved Hide resolved

untrusted/src/lib.rs Outdated Show resolved Hide resolved

untrusted/src/lib.rs Outdated Show resolved Hide resolved

untrusted/test_enclave/build.rs Outdated Show resolved Hide resolved

untrusted/test_enclave/build.rs Show resolved Hide resolved

untrusted/test_enclave/src/config.xml Show resolved Hide resolved

untrusted/test_enclave/src/enclave.c Show resolved Hide resolved

nick-mobilecoin commented

View reviewed changes

Collaborator Author

nick-mobilecoin left a comment

accidentally hit the review button instead of the respond, ingore this review...

untrusted/test_enclave/build.rs Show resolved Hide resolved

jcape assigned nick-mobilecoin

jcape reviewed

View reviewed changes

untrusted/src/lib.rs Outdated Show resolved Hide resolved

remoun reviewed

View reviewed changes

untrusted/Cargo.toml Outdated Show resolved Hide resolved

untrusted/test_enclave/build.rs Outdated Show resolved Hide resolved

untrusted/urts/README.md Outdated Show resolved Hide resolved

untrusted/urts/src/lib.rs Outdated Show resolved Hide resolved

nick-mobilecoin requested review from jcape, remoun and a team

May 11, 2022 16:19

remoun reviewed

View reviewed changes

untrusted/test_enclave/README.md Outdated Show resolved Hide resolved

untrusted/test_enclave/build.rs Outdated Show resolved Hide resolved

untrusted/test_enclave/build.rs Outdated Show resolved Hide resolved

untrusted/test_enclave/build.rs Outdated Show resolved Hide resolved

untrusted/urts/Cargo.toml Outdated Show resolved Hide resolved

untrusted/urts/src/lib.rs Outdated Show resolved Hide resolved

untrusted/urts_sys/build.rs Outdated Show resolved Hide resolved

untrusted/test_enclave/README.md Outdated Show resolved Hide resolved

nick-mobilecoin requested a review from a team

May 17, 2022 15:18

remoun previously approved these changes

View reviewed changes

Contributor

remoun left a comment

LGTM

untrusted/urts/src/lib.rs Outdated Show resolved Hide resolved

untrusted/urts/src/lib.rs Show resolved Hide resolved

untrusted/urts_sys_types/src/lib.rs Outdated Show resolved Hide resolved

untrusted/urts_sys/src/lib.rs Outdated Show resolved Hide resolved

untrusted/test_enclave/src/lib.rs Outdated Show resolved Hide resolved

nick-mobilecoin dismissed remoun’s stale review via

69bd0f0

May 18, 2022 14:01

remoun previously approved these changes

View reviewed changes

untrusted/urts/src/lib.rs Outdated Show resolved Hide resolved

untrusted/urts/src/lib.rs Outdated Show resolved Hide resolved

nick-mobilecoin dismissed remoun’s stale review via

3d93705

May 19, 2022 14:01

remoun previously approved these changes

View reviewed changes

Contributor

remoun left a comment

LGTM

untrusted/urts/src/lib.rs Outdated Show resolved Hide resolved

untrusted/urts/src/lib.rs Outdated Show resolved Hide resolved

nick-mobilecoin dismissed remoun’s stale review via

826eb95

May 19, 2022 17:03

nick-mobilecoin mentioned this pull request

Add FFI support for enclave quoting #14

Closed

nick-mobilecoin changed the base branch from main to feature/sgx_status_t

July 12, 2022 15:42

nick-mobilecoin force-pushed the feature/untrusted branch from 826eb95 to b19de32 Compare

July 12, 2022 15:42

nick-mobilecoin mentioned this pull request

Add FFI for sgx_status_t #23

Merged

Collaborator Author

nick-mobilecoin commented Jul 12, 2022 •

edited

Loading

Current dependencies on/for this PR:

develop
- PR Add FFI for sgx_status_t #23
  - PR Add rust interface to untrusted SGX #2 👈
    - PR Add github actions to run untrusted tests #24
      - PR Add trts rust interface #6
        
        PR Add mc-sgx-core-build crate #26
        
        PR Add rust bindings for SGX crypto library #8
        
        PR Initial add of tservice crate #9
        
        PR Remove test check from no_std usage #30
        
        PR github actions now check for lock file changes #31

This comment was auto-generated by Graphite.

Collaborator Author

nick-mobilecoin commented Jul 12, 2022

Updated the generated bindings for b19de32

nick-mobilecoin mentioned this pull request

Add github actions to run untrusted tests #24

Merged

jcape approved these changes

View reviewed changes

untrusted/urts/src/lib.rs Outdated Show resolved Hide resolved

core/sys/types/build.rs Show resolved Hide resolved

untrusted/quote_verify/src/lib.rs Show resolved Hide resolved

untrusted/quote_verify/src/lib.rs Outdated Show resolved Hide resolved

nick-mobilecoin force-pushed the feature/untrusted branch from a2f9ce8 to c8fde4e Compare

July 13, 2022 21:24

nick-mobilecoin mentioned this pull request

Add trts rust interface #6

Merged

nick-mobilecoin requested a review from a team

July 14, 2022 13:57

This was referenced Jul 14, 2022

Bindgen-based crates for intel SGX SDK #3

Closed

Add mc-sgx-core-build crate #26

Merged

Add rust bindings for SGX crypto library #8

Merged

Initial add of tservice crate #9

Merged

Base automatically changed from feature/sgx_status_t to develop

July 15, 2022 22:37

nick-mobilecoin force-pushed the feature/untrusted branch from c8fde4e to 62e6bbc Compare

July 15, 2022 22:48

jcape removed the request for review from a team

July 18, 2022 17:25

NotGyro removed their request for review

July 20, 2022 17:38

awygle self-requested a review

July 20, 2022 18:24

awygle reviewed

View reviewed changes

core/sys/types/build.rs Show resolved Hide resolved

awygle approved these changes

View reviewed changes

Contributor

awygle left a comment

LGTM.


          Add rust interface to untrusted SGX

bb8717c

Add a rust interface for the untrusted side of the SGX interface.  This
provides the capability to create enclaves and call into them.

nick-mobilecoin force-pushed the feature/untrusted branch from 62e6bbc to bb8717c Compare

July 20, 2022 20:17

nick-mobilecoin merged commit 0e9e68e into develop

nick-mobilecoin deleted the feature/untrusted branch

July 20, 2022 20:18

This was referenced Jul 21, 2022

Remove test check from no_std usage #30

Merged

github actions now check for lock file changes #31

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet