Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppCreateResponse: add split between app page URL and logs page URL #2185

Merged
merged 1 commit into from
Sep 3, 2024
Merged

AppCreateResponse: add split between app page URL and logs page URL #2185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modal/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ async def _init_local_app_new(
app_state=app_state,
)
app_resp = await retry_transient_errors(client.stub.AppCreate, app_req)
app_page_url = app_resp.app_logs_url
app_page_url = app_resp.app_page_url
logger.debug(f"Created new app with id {app_resp.app_id}")
return RunningApp(
app_resp.app_id, app_page_url=app_page_url, environment_name=environment_name, interactive=interactive
Expand Down
3 changes: 2 additions & 1 deletion modal_proto/api.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,8 @@ message AppCreateRequest {

message AppCreateResponse {
string app_id = 1;
string app_logs_url = 2;
string app_page_url = 2;
string app_logs_url = 3;
}

message AppDeployRequest {
Expand Down
2 changes: 1 addition & 1 deletion test/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ async def AppCreate(self, stream):
app_id = f"ap-{self.n_apps}"
self.app_state_history[app_id].append(api_pb2.APP_STATE_INITIALIZING)
await stream.send_message(
api_pb2.AppCreateResponse(app_id=app_id, app_logs_url="https://modaltest.com/apps/ap-123")
api_pb2.AppCreateResponse(app_id=app_id, app_page_url="https://modaltest.com/apps/ap-123")
)

async def AppClientDisconnect(self, stream):
Expand Down
Loading