Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppCreateResponse: add split between app page URL and logs page URL #2185

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

thundergolfer
Copy link
Contributor

@thundergolfer thundergolfer commented Sep 3, 2024

Describe your changes

Last night when dog-fooding I hit a broken link:

Stopping app - keyboard interrupt received. Use `modal run --detach` to prevent KeyboardInterrupts from killing apps.
Timed out waiting for logs. View logs at https://modal.com/logs/ap-n6SUuGWdBCufjNisSwx2Ep for remaining output.

Sometimes the app overview page is best and sometimes we should take the client directly to the logs page (or tab, whichever). So I'm adding both URL options to the proto.

  • MOD-3658
Backward/forward compatibility checks

Check these boxes or delete any item (or this section) if not relevant for this PR.

  • Client+Server: this change is compatible with old servers
    • yes, old servers will continue to send the app_logs_url on field 2, which is compatible data because this is just a rename.
  • Client forward compatibility: this change ensures client can accept data intended for later versions of itself

Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.


Copy link
Contributor

@mwaskom mwaskom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thundergolfer thundergolfer merged commit d22e3ef into main Sep 3, 2024
25 checks passed
@thundergolfer thundergolfer deleted the jonathon/rework-app_logs_url branch September 3, 2024 21:16
@thundergolfer thundergolfer mentioned this pull request Sep 3, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants