Usability improvements (redux) #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eramongodb
requested changes
Aug 27, 2024
Co-authored-by: Ezra Chung <[email protected]>
Co-authored-by: Ezra Chung <[email protected]>
Co-authored-by: Ezra Chung <[email protected]>
Co-authored-by: Ezra Chung <[email protected]>
Co-authored-by: Ezra Chung <[email protected]>
Co-authored-by: Ezra Chung <[email protected]>
Co-authored-by: Ezra Chung <[email protected]>
eramongodb
requested changes
Aug 27, 2024
| echo "Finding Python3 binary..." | ||
| PYTHON="$(find_python3 2>/dev/null)" || return | ||
| echo "Finding Python3 binary... done." | ||
| PYTHON=$(ensure_python3) || return |
There was a problem hiding this comment.
Unsure if Auth AWS test failures are related to changes in this PR.
There was a problem hiding this comment.
It looks like removing rm -rf mongodb will fix this one too: /tmp/test.sh: line 15: /root/mongosh: No such file or directory.
Co-authored-by: Ezra Chung <[email protected]>
Co-authored-by: Ezra Chung <[email protected]>
Co-authored-by: Ezra Chung <[email protected]>
eramongodb
approved these changes
Aug 27, 2024
| @@ -4,6 +4,7 @@ all: | |||
| @echo "Project successfully compiled" | |||
|
|
|||
| run-server: | |||
| rm -rf mongodb | |||
There was a problem hiding this comment.
May prefer moving this into a clean target instead of being part of the run-server target.
|
Thanks @eramongodb! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A redo of #473 based on feedback from @eramongodb
pathlib.Path().expanduser()on Windowsrun-serverandstop-server