Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usability improvements (redux) #477

Merged
merged 19 commits into from
Aug 27, 2024
Merged

Usability improvements (redux) #477

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
f423fd8
Usability improvements (#473)
blink1073 Aug 26, 2024
708cb95
address review
blink1073 Aug 27, 2024
d9c6aa8
address shellcheck for sh
blink1073 Aug 27, 2024
6f53862
missed a return
blink1073 Aug 27, 2024
cf1652f
fix handling of local .bin
blink1073 Aug 27, 2024
4750149
Update .evergreen/download-mongodb.sh
blink1073 Aug 27, 2024
4f6c777
Update .evergreen/download-mongodb.sh
blink1073 Aug 27, 2024
b82f332
Update .evergreen/find-python3.sh
blink1073 Aug 27, 2024
1eac52d
Update .evergreen/handle-paths.sh
blink1073 Aug 27, 2024
dc37c83
Update .evergreen/handle-paths.sh
blink1073 Aug 27, 2024
33ec005
Update .evergreen/stop-orchestration.sh
blink1073 Aug 27, 2024
34517f3
Update Makefile
blink1073 Aug 27, 2024
2658776
address review
blink1073 Aug 27, 2024
968b936
Update .evergreen/download-mongodb.sh
blink1073 Aug 27, 2024
2f1aa62
Update .evergreen/download-mongodb.sh
blink1073 Aug 27, 2024
49f8b42
Update .evergreen/download-mongodb.sh
blink1073 Aug 27, 2024
75d8d87
address review
blink1073 Aug 27, 2024
6a6a558
remove mongodb directory when running server
blink1073 Aug 27, 2024
3fdcd47
address review
blink1073 Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions .evergreen/download-mongodb.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -699,8 +699,13 @@ download_and_extract_package ()
MONGODB_DOWNLOAD_URL=$1
EXTRACT=$2

cd "$(dirname "$(dirname "${MONGODB_BINARIES:?}")")"
rm -rf mongodb
if [ -n "${MONGODB_BINARIES:-}" ]; then
cd "$(dirname "$(dirname "${MONGODB_BINARIES:?}")")"
else
SCRIPT_DIR=$(dirname ${BASH_SOURCE:-$0})
. $SCRIPT_DIR/handle-paths.sh
cd $DRIVERS_TOOLS
fi

echo "Installing server binaries..."
curl_retry $MONGODB_DOWNLOAD_URL --output mongodb-binaries.tgz
Expand All @@ -725,8 +730,13 @@ download_and_extract_mongosh ()
get_mongodb_download_url_for $(get_distro) latest false
fi

cd $(dirname $(dirname ${MONGODB_BINARIES:?}))
rm -rf mongosh
if [ -n "${MONGODB_BINARIES:-}" ]; then
cd "$(dirname "$(dirname "${MONGODB_BINARIES:?}")")"
else
SCRIPT_DIR=$(dirname ${BASH_SOURCE:-$0})
. $SCRIPT_DIR/handle-paths.sh
cd $DRIVERS_TOOLS
fi

echo "Installing MongoDB shell..."
curl_retry $MONGOSH_DOWNLOAD_URL --output mongosh.tgz
Expand Down
1 change: 1 addition & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ all:
@echo "Project successfully compiled"

run-server:
rm -rf mongodb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May prefer moving this into a clean target instead of being part of the run-server target.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

.evergreen/run-orchestration.sh

stop-server:
Expand Down
Loading