Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Information metadata on Interactive UI #1039

Merged
merged 7 commits into from
Jan 17, 2024

Conversation

M6AI
Copy link
Contributor

@M6AI M6AI commented Dec 30, 2023

Bug / Requirement Description

Interactive UI does not receive information metadata during serialization.

Solution description

Added information metadata to the interactive UI.

Checklist:

  • Test
  • Example (both test_plan.py and .rst)
  • Documentation (API)
  • News fragment present for release notes
  • MS info leakage check
  • For new driver: driver index page
  • For new assertion: ui/pdf/std renderers, documentation
  • For new cmdline arg: documentation

@M6AI M6AI requested a review from Pyifan as a code owner December 30, 2023 15:22
@@ -122,6 +122,7 @@ def http_handler_info(self):
def setup(self):
"""Set up the task pool and HTTP handler."""
self.target.make_runpath_dirs()
self.report.information.append(("runpath", self.target.runpath))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest move this to TestRunner define_runpath()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested moving it, it is not sufficient. The trick is that the interactive handler derives the runpath to its own report (created with _initial_report call) from the target. It does not really know any other way. So even if we move to TestRunner that just means that those objects will know about their runpath in information field, but the interactive handler works with a different report at top level.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. ihandler has its own top level report rather than using the report of the target (TestRunner).

btw, the report will be regenerated when we reload, I doubt we will lost the runpath info.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Info is persisted upon a check.

@M6AI M6AI merged commit 8f53b0d into morganstanley:main Jan 17, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants