-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Information metadata on Interactive UI #1039
Information metadata on Interactive UI #1039
Conversation
@@ -122,6 +122,7 @@ def http_handler_info(self): | |||
def setup(self): | |||
"""Set up the task pool and HTTP handler.""" | |||
self.target.make_runpath_dirs() | |||
self.report.information.append(("runpath", self.target.runpath)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest move this to TestRunner define_runpath()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested moving it, it is not sufficient. The trick is that the interactive handler derives the runpath to its own report (created with _initial_report call) from the target. It does not really know any other way. So even if we move to TestRunner that just means that those objects will know about their runpath in information field, but the interactive handler works with a different report at top level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. ihandler has its own top level report rather than using the report of the target (TestRunner).
btw, the report will be regenerated when we reload, I doubt we will lost the runpath info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Info is persisted upon a check.
Bug / Requirement Description
Interactive UI does not receive information metadata during serialization.
Solution description
Added information metadata to the interactive UI.
Checklist: