-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Information metadata on Interactive UI #1039
Merged
M6AI
merged 7 commits into
morganstanley:main
from
M6AI:feature/information_panel_interactive
Jan 17, 2024
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b6cb419
Added information metadata to the interactive UI.
M6AI 52f912e
Merge branch 'main' into feature/information_panel_interactive
M6AI f2cbbfc
Merge branch 'main' into feature/information_panel_interactive
M6AI 24b015b
Merge branch 'main' into feature/information_panel_interactive
M6AI eb9103f
Merge branch 'main' into feature/information_panel_interactive
M6AI affca27
Merge branch 'main' into feature/information_panel_interactive
M6AI fcc7e46
Merge branch 'main' into feature/information_panel_interactive
M6AI File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Testplan interactive UI now supplies information metadata to the info panel accessible on the toolbar. It contains runpath in addition to the ones used in the static report browser UI. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest move this to TestRunner define_runpath()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested moving it, it is not sufficient. The trick is that the interactive handler derives the runpath to its own report (created with _initial_report call) from the target. It does not really know any other way. So even if we move to TestRunner that just means that those objects will know about their runpath in information field, but the interactive handler works with a different report at top level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. ihandler has its own top level report rather than using the report of the target (TestRunner).
btw, the report will be regenerated when we reload, I doubt we will lost the runpath info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Info is persisted upon a check.