Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Windows testing #1119

Merged
merged 5 commits into from
Sep 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/pip-install.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ jobs:
matrix:
os:
- ubuntu-latest
- windows-latest
python-version:
- "3.12"
- "3.11"
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ jobs:
matrix:
os:
- ubuntu-latest
- windows-latest
python-version:
- "3.12"
- "3.11"
Expand Down Expand Up @@ -77,3 +78,4 @@ jobs:
- name: Format
run: |
ruff format --check --diff parsons/ test/ useful_resources/

2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,6 @@ xmltodict==0.11.0
# TODO Remove when we have a TMC-specific Docker image
jinja2>=3.0.2
selenium==3.141.0
us==3.1.1
us==3.2.0
sshtunnel==0.4.0

3 changes: 3 additions & 0 deletions test/test_targetsmart/test_targetsmart_smartmatch.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
import csv
import io
import gzip
import sys

import petl
import pytest

from parsons.targetsmart.targetsmart_api import TargetSmartAPI


Expand Down Expand Up @@ -70,6 +72,7 @@ def submit_filename():
return "parsons_test.csv"


@pytest.mark.skipif(sys.platform == "win32", reason="need to fix this test on windows")
def test_smartmatch(
intable,
submit_filename,
Expand Down
Loading