Implement Windows testing #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
shaunagm
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
We have so many tests now! Although soon we'll remove a chunk of them when we drop 3.8 support.
Thank you for doing this! Let's make sure to add an issue for the test we removed - it would be good to get it fixed and back up. HT @jdw25 for keeping our issue tracker honest :)
|
Here it is, just needs to have the tags and stuff set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically ready to merge, but there is one failing test I have not figured out. It is unable to read the test csv file with a permissions error:
https://github.com/move-coop/parsons/actions/runs/10727584933/job/29750246811?pr=1119