Closes #2522: Removed mutable pending intent flags #2532
Conversation
Having mutable pending intents is disallowed on android 14+ and results in app crashing on launch. I don't think there was any particular reason why the PendingIntets we are using were set to be mutable instead of immutable – we are creating new PendingIntent for each tab, without intention to alter (or override in this case) existing ones. My hunch, the system was using mutable flags by default prior to API 31, so the behaviour was kept the same.
|
While testing the behaviour of mutable and immutable flags, I found another bug: If we send the same tab multiple times, only the first one will work. Will create a follow up. Edited: the follow up. |
|
@mcarare |
|
Thanks for tagging me, I will keep this in mind to retest for the Fenix targeting 34 PR. |
|
That's a great point, we should do that. Because right now the tab will be opened by the default browser that might not be the RB. Filled an issue. Do you think we could avoid changing flags? From what I can see, the pending intent requires a mutability flag, and android 14 requires it to be set to immutable. btw, I don't have rights to set tags, could you help me merging it? @mcarare |
Having mutable pending intents is disallowed on android 14+ and results in app crashing on launch. I don't think there was any particular reason why the PendingIntets we are using were set to be mutable instead of immutable – we are creating new PendingIntent for each tab, without intention to alter (or override in this case) existing ones. My hunch, the system was using mutable flags by default prior to API 31, so the behaviour was kept the same.
Pull Request checklist