Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2522: Removed mutable pending intent flags #2532

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Closes #2522: Removed mutable pending intent flags #2532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c607a6
Closes #2522: Removed mutable pending intent flags
Oct 18, 2023
54737bd
Merge branch 'master' into fix_android_14_launch_crash
mergify[bot] Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/src/main/java/org/mozilla/reference/browser/NotificationManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ object NotificationManager {
flags = Intent.FLAG_ACTIVITY_NEW_TASK
}
val flags = if (SDK_INT >= Build.VERSION_CODES.S) {
PendingIntent.FLAG_MUTABLE or PendingIntent.FLAG_ONE_SHOT
PendingIntent.FLAG_IMMUTABLE or PendingIntent.FLAG_ONE_SHOT
} else {
PendingIntent.FLAG_ONE_SHOT
}
Expand Down Expand Up @@ -130,7 +130,7 @@ object NotificationManager {
}

val flags = if (SDK_INT >= Build.VERSION_CODES.S) {
PendingIntent.FLAG_MUTABLE
PendingIntent.FLAG_IMMUTABLE
} else {
0
}
Expand Down
3 changes: 1 addition & 2 deletions app/src/main/java/org/mozilla/reference/browser/components/Analytics.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
package org.mozilla.reference.browser.components

import android.app.PendingIntent
import android.app.PendingIntent.FLAG_MUTABLE
import android.content.Context
import android.content.Intent
import android.os.Build
Expand Down Expand Up @@ -54,7 +53,7 @@ class Analytics(private val context: Context) {
}

val flags = if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) {
FLAG_MUTABLE
PendingIntent.FLAG_IMMUTABLE
} else {
0
}
Expand Down