make process_output be able to return keep_alive timeout #2136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KershawChang
requested review from
martinthomson,
larseggert and
mxinden
as code owners
larseggert
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
LGTM.
So all the test changes revert what was done in #1491?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2136 +/- ##
==========================================
- Coverage 95.35% 95.35% -0.01%
==========================================
Files 112 112
Lines 36336 36357 +21
==========================================
+ Hits 34648 34668 +20
- Misses 1688 1689 +1 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to 824d7c4. coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [99.061 ns 99.675 ns 100.48 ns]
change: [-6.8172% -2.3726% +0.2961%] (p = 0.32 > 0.05)
coalesce_acked_from_zero 3+1 entries: Change within noise threshold. time: [116.63 ns 116.91 ns 117.21 ns]
change: [-1.1534% -0.7157% -0.2621%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [116.23 ns 116.72 ns 117.31 ns]
change: [-1.2371% -0.6152% +0.1547%] (p = 0.07 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [97.216 ns 97.363 ns 97.523 ns]
change: [-1.7227% -0.7616% +0.0880%] (p = 0.11 > 0.05)
RxStreamOrderer::inbound_frame(): No change in performance detected. time: [111.19 ms 111.25 ms 111.31 ms]
change: [-0.0708% +0.1425% +0.2870%] (p = 0.13 > 0.05)
transfer/pacing-false/varying-seeds: Change within noise threshold. time: [27.424 ms 28.656 ms 29.894 ms]
change: [+1.0141% +6.7524% +13.208%] (p = 0.03 < 0.05)
transfer/pacing-true/varying-seeds: Change within noise threshold. time: [37.013 ms 38.881 ms 40.743 ms]
change: [+2.0478% +8.5685% +15.609%] (p = 0.02 < 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [26.530 ms 27.429 ms 28.352 ms]
change: [-1.2476% +3.3788% +8.1859%] (p = 0.15 > 0.05)
transfer/pacing-true/same-seed: Change within noise threshold. time: [44.293 ms 46.734 ms 49.212 ms]
change: [+1.2376% +8.6392% +16.890%] (p = 0.03 < 0.05)
1-conn/1-100mb-resp (aka. Download)/client: Change within noise threshold. time: [112.42 ms 112.83 ms 113.22 ms]
thrpt: [883.27 MiB/s 886.30 MiB/s 889.53 MiB/s]
change:
time: [-1.9247% -1.3603% -0.8195%] (p = 0.00 < 0.05)
thrpt: [+0.8263% +1.3791% +1.9625%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [310.11 ms 313.92 ms 317.71 ms]
thrpt: [31.475 Kelem/s 31.856 Kelem/s 32.246 Kelem/s]
change:
time: [-2.6371% -0.9932% +0.6941%] (p = 0.24 > 0.05)
thrpt: [-0.6893% +1.0031% +2.7086%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [33.838 ms 34.050 ms 34.281 ms]
thrpt: [29.170 elem/s 29.368 elem/s 29.552 elem/s]
change:
time: [-1.4553% -0.6774% +0.2187%] (p = 0.11 > 0.05)
thrpt: [-0.2182% +0.6821% +1.4768%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Yes, correct. |
mxinden
reviewed
Sep 26, 2024
KershawChang
force-pushed
the
idle_timeout
branch
from
0aa9c54
to
f0fe2d2
Compare
mxinden
approved these changes
Oct 1, 2024
|
Merging |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
KershawChang
force-pushed
the
idle_timeout
branch
from
6e1f4c0
to
b5b887d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2087