Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unique codes for each error message #5

Merged
merged 8 commits into from
Jul 17, 2024
Merged

Add unique codes for each error message #5

merged 8 commits into from
Jul 17, 2024

Conversation

richfitz
Copy link
Member

@richfitz richfitz commented Jul 15, 2024

This PR adds a unique error code for each error that we throw. For example E1007 means that the user has provided a default argument to parameter() that is too complicated for us to work this. Each call to odin_parse_error includes a code, and each code has an entry in the errors vignette. There's also a basic odin_error_explain function which will (currently) link to the vignette.

This is all likely to expand over time, some future directions are described in comments.

Merge after #4 as it contains those commits

@richfitz richfitz marked this pull request as ready for review July 16, 2024 06:57
@richfitz richfitz requested a review from weshinsley July 16, 2024 07:02
Copy link
Contributor

@weshinsley weshinsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! (Especially the RStudio integration... spectacular...)

vignettes/errors.Rmd Outdated Show resolved Hide resolved
vignettes/errors.Rmd Outdated Show resolved Hide resolved
vignettes/errors.Rmd Outdated Show resolved Hide resolved
@weshinsley weshinsley merged commit f4daf0e into main Jul 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants