Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphics/waveforms.py refactoring #281

Merged
merged 9 commits into from
Jan 17, 2025
Merged

graphics/waveforms.py refactoring #281

merged 9 commits into from
Jan 17, 2025

Conversation

rmodrak
Copy link
Member

@rmodrak rmodrak commented Nov 18, 2024

Trying to add the following

  • better handling of empty datasets and other special cases
  • testing coverage (tests/test_graphics.py)
  • improved code readability

Tentatively aiming to merge after Dec 14

@thurinj
Copy link
Member

thurinj commented Nov 20, 2024

Hi @rmodrak ,

I need to check your branch to test it out. Looking at the changes made in waveforms.py it all looks great to me, the code is much more cleaner than previous version!

(Sorry for sticking that much to the previously established code in my last merge, it probably ended up adding you some work!)

@rmodrak
Copy link
Member Author

rmodrak commented Nov 20, 2024

I was also checking that the different waveform normalization options continue to work-- will try to post the result later.

@rmodrak
Copy link
Member Author

rmodrak commented Jan 13, 2025

Planning to merge this soon

@rmodrak rmodrak merged commit 086dabc into mtuqorg:master Jan 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants